KAFKA-19990: gracefully handle exceptions when handling AllocateProducerIdsResponse #21135
+122
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Contributor
Author
Contributor
|
Thanks @gaurav-narula for the fix, It looks okay for me let's wait for the pipeline to finish first |
chia7712
reviewed
Dec 12, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@gaurav-narula thanks for this patch
...coordinator/src/main/java/org/apache/kafka/coordinator/transaction/RPCProducerIdManager.java
Outdated
Show resolved
Hide resolved
...coordinator/src/main/java/org/apache/kafka/coordinator/transaction/RPCProducerIdManager.java
Outdated
Show resolved
Hide resolved
...coordinator/src/main/java/org/apache/kafka/coordinator/transaction/RPCProducerIdManager.java
Outdated
Show resolved
Hide resolved
…cerIdsResponse The handler in `RPCProducerIdManager` doesn't handle authentication exception and version mismatch exceptions gracefully. This change ensures we retry on such failures and adds unit tests for these scenarios.
Member
|
@gaurav-narula could you please file the patch to 3.9 in addition to trunk? |
gaurav-narula
force-pushed
the
KAFKA-19990
branch
from
0a42920 to
d00273f
Compare
Contributor
Author
chia7712
reviewed
Dec 14, 2025
|
|
||
| private final int brokerId; | ||
| private final Time time; | ||
| protected final Time time; |
Member
There was a problem hiding this comment.
nit: package-private is sufficient here
| } | ||
|
|
||
| protected void handleAllocateProducerIdsResponse(AllocateProducerIdsResponse response) { | ||
| protected void handleUnsuccessfulResponse() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler in
RPCProducerIdManagerdoesn't handle authenticationexception and version mismatch exceptions gracefully.
This change ensures we retry on such failures and adds unit tests for
these scenarios.