Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR makes sync faster and reduces memory footprint by adding a shared source-side option to skip column stats extraction:
xtable.source.skip_column_stats=trueThe flag now works consistently for Hudi, Delta, and Iceberg sources.
In practical terms, this is intended for heavy tables where stats extraction is a bottleneck.
Example from large-sync behavior: a job that previously took around 6 hours and required >64 GB Xmx can be reduced to around 1 hour with about 10 GB Xmx.
Brief change log
xtable.source.skip_column_stats) instead of per-format keys.Verify this pull request
This change added tests and can be verified as follows:
ITConversionControllerfor:xtable.source.skip_column_stats: true / falsemvn -pl xtable-core -Dtest=ITConversionController#testSkipColumnStatsAcrossSources testmvn -pl xtable-core -DskipTests compileTrade-offs
xtable.source.skip_column_stats=true, column stats are not extracted or propagated.