Update metadata-log for non-rest catalogs #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
Aug 1, 2024
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for working on this, I left a few comments
kevinjqliu
reviewed
Aug 1, 2024
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for the response, i added a few more comments about tests
soumya-ghosh
force-pushed
the
fix/update_metadata_log
branch
from
46e60b6 to
d71fde1
Compare
HonahX
reviewed
Aug 5, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
@soumya-ghosh Thanks for working on this! And thanks @kevinjqliu for reviewing!
I just have one comment about adding the new property to doc. Other than that it looks great!
kevinjqliu
approved these changes
Aug 5, 2024
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the new option to the docs
HonahX
approved these changes
Aug 6, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
Thanks for adding the doc!
soumya-ghosh
force-pushed
the
fix/update_metadata_log
branch
from
c2fdec7 to
a8f1e2b
Compare
kevinjqliu
approved these changes
Aug 6, 2024
Contributor
|
Waiting for CI to run. |
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Update metadata-log for non-rest catalogs * Add test for invalid value of previous-versions-max property * Update configuration docs with previous-versions-max property * Remove reference of PropertyUtil
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Update metadata-log for non-rest catalogs * Add test for invalid value of previous-versions-max property * Update configuration docs with previous-versions-max property * Remove reference of PropertyUtil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #849
Also added support to control size of
metadata-logusingwrite.metadata.previous-versions-maxproperty.