[FEAT]register table using iceberg metadata file via pyiceberg #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
May 14, 2024
HonahX
reviewed
May 21, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
Sorry for being late here. It looks great! Thanks for completing the last piece of GlueCatalog :)
Just have one suggestion for the integration test.
HonahX
approved these changes
May 22, 2024
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
@MehulBatra Thanks for updating the test!. Thanks @kevinjqliu for reviewing!
Contributor
Author
Thank you @kevinjqliu and @HonahX for the great collaboration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.