add_files support partitioned tables
#531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Mar 19, 2024
Fokko
reviewed
Mar 19, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
@syun64 Thanks for working on this, this looks great!
Collaborator
Author
Thank you very much for the detailed review @Fokko . I've adopted all of your review comments 👍 - I would appreciate another round of review! |
Fokko
approved these changes
Mar 21, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
This looks good, thanks again for the work @syun64
Collaborator
Author
Thank you! As always! @Fokko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #506, this PR introduces the support for adding files as DataFiles to partitioned tables.
Instead of relying on the more inaccurate method of parsing and inferring partition values from the file path relying on a Hive partitioning scheme, this approach requires that the partition values are there in the parquet files, and infers the partition values from the partition metadata footer by taking using the lower and upper bound values.
The optimization to use the lower bound and upper bound values prevents the client from having to read the entire parquet file as it is able to use the aggregated statistics from the parquet metadata footer. As a result, this implementation of add_files does not support tables with partition transforms that are non-linear (not
preserves_order).Among the existing Transforms, the following Transform partitions are supported:
The following are not: