Add syntactic sugar for and and or operation
#1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got inspired by Arrow that also allows for this.
kevinjqliu
approved these changes
Feb 21, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Love the dunders
https://docs.python.org/3/reference/datamodel.html#object.__or__
kevinjqliu
pushed a commit
that referenced
this pull request
Feb 24, 2025
Now we have the syntactic sugar (#1697), we don't need Lambda's anymore and can use the `operator.{and_,or_}` functions. Also, the reduce is okay with just having a single argument, while `And(*[EqualTo('a', 22)])` would fail. ``` python3 Python 3.10.14 (main, Mar 19 2024, 21:46:16) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import functools >>> functools.reduce(lambda a, b: a + b, [1]) 1 >>> functools.reduce(lambda a, b: a + b, [1, 2]) 3 ```
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
I got inspired by Arrow that also allows for this.
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
Now we have the syntactic sugar (apache#1697), we don't need Lambda's anymore and can use the `operator.{and_,or_}` functions. Also, the reduce is okay with just having a single argument, while `And(*[EqualTo('a', 22)])` would fail. ``` python3 Python 3.10.14 (main, Mar 19 2024, 21:46:16) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import functools >>> functools.reduce(lambda a, b: a + b, [1]) 1 >>> functools.reduce(lambda a, b: a + b, [1, 2]) 3 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got inspired by Arrow that also allows for this.