-
Notifications
You must be signed in to change notification settings - Fork 418
Closed
Description
Feature Request / Improvement
Java and Python have a different approach here. I don't have all the historical context, but prior to Iceberg V2 tables, there was no such thing as operations:
I think this is a good thing to validate against.
This should happen in the _commit method of the _SnapshotProducer. Similar to Java:
- We should track what the current snapshot was when the table was loaded initially ([startingSnapshotId](https://github.com/apache/iceberg/blob/bcbbd0344623ffea5b092e2de5debb0bc12892a1/core/src/main/java/org/apache/iceberg/BaseReplacePartitions.java#L30 in Java).
- We refresh the table, so we have the latest snapshots. We check from the
startingSnapshotIdto thecurrent-snapshot-idif any snapshots were added. If this is the case, we want to_validate()if there are any conflicts. - Then we write out the manifest-list
There's also a small section on conflict resolution.
- When doing an `Append`: Adding new data
- All okay: `{Append,Replace,Overwrite,Delete}`, don't affect the operation, and we can just append
- When doing a `Replace`: Replacing existing data (eg. compaction)
- Ok: Append
- Not ok: Replace, Overwrite, Delete. We should fail, and later we can see if there is any overlap (eg compare if they touch the same partitions).
- When doing a `Overwrite`: Adding and deleting data
- Not ok: Append, Replace, Overwrite, Delete. We should fail, and later we can see if there is any overlap (eg compare if they touch the same partitions).
- When doing a `Delete`
- Not ok: Append, Replace, Overwrite, Delete. We should fail, and later we can see if there is any overlap (eg compare if they touch the same partitions/predicate). We should also take into account the difference between MoR and CoW.
Let's only do the very simple cases at first, so we can add ones one by one to keep the PR within reasonable size.
Once we have this in place, we can also do automatic retries: #269
TennyZhuang, YinZheng-Sun and lfrkncht
Metadata
Metadata
Assignees
Labels
No labels
