Skip to content

Conversation

@palvitgarg1
Copy link

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)

Description

  • Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

GrantPSpencer and others added 30 commits April 22, 2025 13:28
Merge master into dev
 - Add isInstanceDrained method in HelixAdmin
 - Expose the method via instance update rest end point
 - Change the conditional checks order in isEvacuateFinished to improve
   latency
* this change returns false if the current state contains any resource with rebalance mode full auto or customized
Merge Apache Helix head into dev branch for internal release.
* Adding a new CrushEd2Rebalance Strategy which has CrushEd as base

* using MM instead of using controller sycn and stop

* adding doc strings

* Addressed review comments

* removed unnecessary file
Adding dev branch to run CI on raising against dev
…stance (#32)

* adding check if resources are migrated from an unhealthy evacuated instance

* removing comments

* fixing TestErrorReplicaPersist

* addressing review comments

* addressing review comments

* adding log line and removed Rebalance mode parameter

* Changing log leve and updated the documentation

---------

Co-authored-by: Anubhav Agarwal <[email protected]>
…lance

Add support for virtual topology imbalance detection
Merge master into dev for release 1.4.4-dev-202506171200
Fix global lock contention in DistClusterControllerStateModel caused by Optional.empty() singleton
Merge master into dev for  release 1.4.5-dev-202507181030
This commit introduces an optional feature to make WAGED rebalancer behavior
more consistent with CrushEd for disabled partition scenarios. When enabled,
disabled partitions remain in OFFLINE state on their current instances rather
than being immediately reassigned.
…e-to-relax-disabled-parition-hard-contraint

Add optional relaxed disabled partition constraint for WAGED rebalancer
LZD-PratyushBhatt and others added 29 commits September 22, 2025 17:06
… calculate assignment (apache#3034) (#56)

* prevent DROPPED messages when mapping cannot be computed

* add test for CRUSHED resource

* add message generation phase tst

* fix test

* respond feedback

Co-authored-by: Grant Paláu Spencer <[email protected]>
…te topology nodes (#53)

* Preserve IdealState when Topology exception is encountered

* Add tests

* Fix tests

* Verify message dropped fix using test

* Add integration test

* Added assertion for verifier failrue
…eated workflows (#55)

* Fix stale cache issue causing erroneous workflow deletion in WorkflowDispatcher

* Address review comments

* Remove redundant tests
…ns invalid hash (#61)

* handling the case when jenkins hash returns 0 in straw2selector

* removing unwanted lines

* improving test case and addressing review comments

---------

Co-authored-by: Anubhav Agarwal <[email protected]>
* Add Cluster-Level Instance Operation Count Metrics

* Address review comments

* Address review comments3
* Add Instance Operation Duration Metrics for Monitoring

* Address review comments

* Address review comments2

* Address review comments n

* Address review comments n
* adding cluster topology validation when updating instance config

* formatting the code

* updated the logic to check the instance operation transition

---------

Co-authored-by: Anubhav Agarwal <[email protected]>
* improve stoppable check APIs to include failure details

* fix review comments

---------

Co-authored-by: Laxman Ch <[email protected]>
…in-dev

aajoshi/merge master into linkedin dev
…isation

ReadClusterData Stage Optimisation : ZKCache added in getStat
…tate

Update Ideal State API creating new Ideal State
…tation_parallelization

Added parallelization of resource computation in BestPossibleCalcStage
…Monitor (#71)

* Add partition count and top state partition count metrics to InstanceMonitor

* Fix review comments
…c-stage

aajoshi/improve intermediate calc stage
* Refactor InstanceMonitor to use cluster-level shared executor service

* Added _pendingResetTask for cancelling support, fix unregister and reset logic too

* Simplify InstanceMonitor metric reset to eliminate thread overhead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.