[GOBBLIN-2255] Temporal workflow fast failure#4174
Merged
abhishekmjain merged 4 commits intoapache:masterfrom Mar 11, 2026
Merged
[GOBBLIN-2255] Temporal workflow fast failure#4174abhishekmjain merged 4 commits intoapache:masterfrom
abhishekmjain merged 4 commits intoapache:masterfrom
Conversation
Comment on lines
+97
to
+99
| } catch (IOException e) { | ||
| Throwable cause = e.getCause(); | ||
| if (cause instanceof DSQuotaExceededException || cause instanceof NSQuotaExceededException) { |
Contributor
There was a problem hiding this comment.
can we create a set of non retryable exceptions and check on that instead of writing each exception here?
Contributor
Author
There was a problem hiding this comment.
yes that would be better ✅
adithya2754
commented
Mar 11, 2026
Contributor
Author
There was a problem hiding this comment.
Although trivial added unit tests for util class :)
| return Optional.empty(); | ||
| } | ||
| for (Class<? extends Exception> exClass : EXCEPTIONS) { | ||
| if (exClass.isInstance(throwable)) { |
Contributor
There was a problem hiding this comment.
we should also check for cause recursively, throwable has getClause() which returns null when there is no more underlying cause.
public synchronized Throwable getCause() {
return (cause==this ? null : cause);
}
Contributor
There was a problem hiding this comment.
this will help in identifying cases where the nonRetryableException is nested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Temporal workflow goes on to re-attempt even when there is a non intermittent issue - like when user Quota is Exceeded, where successive attempts will not stop it from failure.
This is to introduce fast failure when we see Quota Exceeded Exceptions during the workflow
Tests
Tested for a flow
Commits