Skip to content

FINERACT-2507: Reduced default poll interval for Loan COB Spring Job from 10s to 500ms#5549

Open
pwargulak wants to merge 1 commit intoapache:developfrom
SolDevelo:develop
Open

FINERACT-2507: Reduced default poll interval for Loan COB Spring Job from 10s to 500ms#5549
pwargulak wants to merge 1 commit intoapache:developfrom
SolDevelo:develop

Conversation

@pwargulak
Copy link

Description

Reduced default poll interval for Loan COB Job from 10s to 500ms.
The poll interval controls how often the spring job manager checks for partition step completion.
Therefore, it also defines minimal execution time.
The lower value makes the check happen more often, which may put pressure on DB.

See related ticket: FINERACT-2507

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

…from 10s to 500ms

The poll interval controls how often the spring job manager checks for partition step completion. Therefore, it also defines minimal execution time. The lower value makes the check happen more often, which may put pressure on DB.
Copy link
Contributor

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pwargulak
Copy link
Author

Failed test log snippet:

org.apache.fineract.integrationtests.client.feign.tests.FeignTrialBalanceSummaryReportTest

    Test testReportReturnsExpectedColumns() PASSED
    Test testExternalAssetOwnerEntriesAppearInReport() FAILED
  
    org.apache.fineract.client.feign.util.CallFailedRuntimeException: HTTP failed: status=403, request=https://localhost:8443/fineract-provider/api/v1/loanproducts, errorBody={"developerMessage":"The request caused a data integrity issue to be fired by the database.","httpStatusCode":"403","defaultUserMessage":"Loan product with short name `21F8` already exists","userMessageGlobalisationCode":"error.msg.product.loan.duplicate.short.name","errors":[{"defaultUserMessage":"Loan product with short name `21F8` already exists","parameterName":"shortName","developerMessage":"Loan product with short name `21F8` already exists","userMessageGlobalisationCode":"error.msg.product.loan.duplicate.short.name","args":[{"value":"21F8"}]}]}
        at app//org.apache.fineract.integrationtests.client.feign.tests.FeignTrialBalanceSummaryReportTest.createLoanProduct(FeignTrialBalanceSummaryReportTest.java:392)
    Caused by: org.apache.fineract.client.feign.FeignException: status 403 (Validation errors: [shortName] Loan product with short name `21F8` already exists)
        at app//org.apache.fineract.integrationtests.client.feign.tests.FeignTrialBalanceSummaryReportTest.createLoanProduct(FeignTrialBalanceSummaryReportTest.java:392)

@adamsaghy
Copy link
Contributor

@pwargulak Restarted the failed test case.

Regarding the signed commit checks, would you mind to setup GPG signature? (for now it will not block the PR, but later we would like to enforce to everybody :) )

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants