Skip to content

FINERACT-2015: Fix saving account with withdrawal fee#5456

Merged
adamsaghy merged 1 commit intoapache:developfrom
SamaSVM:FINERACT-2015/fix-saving-account-with-withdrawal-fee
Feb 11, 2026
Merged

FINERACT-2015: Fix saving account with withdrawal fee#5456
adamsaghy merged 1 commit intoapache:developfrom
SamaSVM:FINERACT-2015/fix-saving-account-with-withdrawal-fee

Conversation

@SamaSVM
Copy link
Contributor

@SamaSVM SamaSVM commented Feb 6, 2026

Description

Fix NullPointerException in SavingsAccount.payWithdrawalFee() when performing account transfers with withdrawal fee enabled. During account transfers, paymentDetail is null because transfers don't use a payment type, but the code unconditionally called paymentDetail.getPaymentType().getName() causing the transaction to fail.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@IOhacker
Copy link
Contributor

IOhacker commented Feb 8, 2026

@SamaSVM There's a new ci action for PRs to check that new commits are signed.

All committers already have PGP/GPG keys, so just make sure you're also signing commits. You can add this to your ~/.gitconfig (or equivalent) to do it automatically:

[commit]
gpgSign = true

Upload your public key to github to make the verified badges green.

More info: FINERACT-2177, PR #5431.

Hints: 1) try it locally before pushing. 2) have git run it for you: Create .git/hooks/pre-push with:

#!/bin/sh
scripts/verify-signed-commits.sh --strict

Be sure to make that script executable.

@SamaSVM SamaSVM force-pushed the FINERACT-2015/fix-saving-account-with-withdrawal-fee branch from 81be71d to 4380a48 Compare February 9, 2026 12:42
@adamsaghy adamsaghy merged commit 840f95c into apache:develop Feb 11, 2026
38 checks passed
@SamaSVM SamaSVM deleted the FINERACT-2015/fix-saving-account-with-withdrawal-fee branch February 17, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants