FINERACT-2015: Fix saving account with withdrawal fee#5456
Merged
adamsaghy merged 1 commit intoapache:developfrom Feb 11, 2026
Merged
Conversation
Contributor
|
@SamaSVM There's a new ci action for PRs to check that new commits are signed. All committers already have PGP/GPG keys, so just make sure you're also signing commits. You can add this to your ~/.gitconfig (or equivalent) to do it automatically: [commit] Upload your public key to github to make the verified badges green. More info: FINERACT-2177, PR #5431. Hints: 1) try it locally before pushing. 2) have git run it for you: Create .git/hooks/pre-push with: #!/bin/sh Be sure to make that script executable. |
81be71d to
4380a48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix NullPointerException in SavingsAccount.payWithdrawalFee() when performing account transfers with withdrawal fee enabled. During account transfers, paymentDetail is null because transfers don't use a payment type, but the code unconditionally called paymentDetail.getPaymentType().getName() causing the transaction to fail.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.