Ignore null LEAD support for small batch sizes.#9445
Merged
comphead merged 8 commits intoapache:mainfrom Mar 4, 2024
Merged
Conversation
github-actions
bot
added
physical-expr
# Conflicts: # datafusion/physical-expr/src/window/lead_lag.rs
comphead
reviewed
Mar 4, 2024
| let end = if self.non_null_offsets.len() == (-self.shift_offset) as usize { | ||
| // How many rows needed further than the current row to get necessary lead result | ||
| let offset: usize = self.non_null_offsets.iter().sum(); | ||
| min(idx + offset + 1, n_rows) |
comphead
approved these changes
Mar 4, 2024
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @mustafasrepo
Contributor
|
I plan to merge it as its a good fix |
wiedld
pushed a commit
to wiedld/arrow-datafusion
that referenced
this pull request
Mar 21, 2024
* IGNORE NULLS support for LEAD * fix * fix * fix * Add lead support when pruned * Update lead_lag.rs Minor changes * Fix formatting --------- Co-authored-by: comphead <comphead@ukr.net> Co-authored-by: Mustafa Akur <akurmustafa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
This PR is a subsequent work of the PR9419 by @comphead .
What changes are included in this PR?
This PR adds support for ignore nulls mode for lead function. When data is received in small batches.
Are these changes tested?
Yes
Are there any user-facing changes?