Skip to content

Fix flaky test_sort_fetch_memory_calculation test #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Sep 13, 2023
Merged

Fix flaky test_sort_fetch_memory_calculation test #7534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/core/src/physical_plan/sorts/sort.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,7 +1097,7 @@ mod tests {
.with_fetch(fetch),
);

let result = collect(sort_exec.clone(), task_ctx).await?;
let result = collect(sort_exec.clone(), task_ctx.clone()).await?;
Copy link
Member Author

@viirya viirya Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

task_ctx is simply moved into task_ctx. Before the stream future is resolved, it could be dropped early which makes DiskManager dropped too. That is why the spill file existed before proceeding into read_spill_as_stream but was deleted intermittently before reading.

assert_eq!(result.len(), 1);

let metrics = sort_exec.metrics().unwrap();
Expand Down