Skip to content

minor: Port more window tests to sqlogictests #5434

Merged
alamb merged 4 commits intoapache:mainfrom
alamb:alamb/final_port_window
Mar 2, 2023
Merged

minor: Port more window tests to sqlogictests #5434
alamb merged 4 commits intoapache:mainfrom
alamb:alamb/final_port_window

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Feb 28, 2023

Which issue does this PR close?

Part of #4495

Follow on to #5330

Rationale for this change

I am trying to keep the testability of DataFusion reasonable. Sqllogictests are easier to add / update so we are trying to move stuff over there.

What changes are included in this PR?

Port more window tests to window.slt

Are these changes tested?

Yes all tests

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Feb 28, 2023
alamb
alamb commented Feb 28, 2023
View reviewed changes
datafusion/core/tests/sql/window.rs
Ok(())
}

fn write_test_data_to_parquet(tmpdir: &TempDir, n_file: usize) -> Result<()> {
Copy link
Contributor Author

@alamb alamb Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file has only a few hundred lines after this one 😅

@alamb alamb changed the title Port more window tests to sqlogictests minor: Port more window tests to sqlogictests Feb 28, 2023
@tustvold
Copy link
Contributor

tustvold commented Mar 1, 2023

There appear to be failing tests?

@alamb
Copy link
Contributor Author

alamb commented Mar 1, 2023 •
edited
Loading

There appear to be failing tests?

Looks like some non deterministic output (a LIMIT without an order by) -- fixed in debdf41

jackwener
jackwener reviewed Mar 1, 2023
View reviewed changes
datafusion/core/tests/sqllogictests/test_files/window.slt



# async fn csv_query_window_with_order_by
Copy link
Member

@jackwener jackwener Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was left on purpose in the past😂

Copy link
Contributor Author

@alamb alamb Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think it adds value I can put them back in 😆 -- I think it was just left over from incomplete porting

@alamb alamb merged commit a95e0ec into apache:main Mar 2, 2023
@ursabot
Copy link

ursabot commented Mar 2, 2023

Benchmark runs are scheduled for baseline = f68214d and contender = a95e0ec. a95e0ec is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwener jackwener jackwener approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alamb @tustvold @ursabot @jackwener