Use _dyn and _scalar_dyn for operations like, ilike, nlike, and nilike to support Dictionary and LargeStringArray#5227
Conversation
…e to support Dictionary and LargeStringArray
comphead
left a comment
There was a problem hiding this comment.
@snmvaughan would be great to have a test showing like* now supports Dictionary and LargeStringArray
|
@comphead Those were the additional tests I planned to add today. |
|
FWIW I am hoping the |
|
Update here is that Perhaps we could add some tests to Here is an example of casting an expression to a Dictionary type |
|
Since this has been open for more than a year, closing it down. Feel free to reopen if/when you keep working on it. |
Which issue does this PR close?
Closes #5222.
Currently a work in progress that handles the scalar case.
What changes are included in this PR?
Replaces a simple check for equality with a coercion based check. Replaces
DataType::Utf8only implementation with the Arrow dyn implementations.Are these changes tested?
Existing tests pass. I'll supplement the tests with additional types.
Are there any user-facing changes?
No