Fix clippy by avoiding deprecated functions in chrono#4189
Merged
alamb merged 2 commits intoapache:masterfrom Nov 12, 2022
Merged
Fix clippy by avoiding deprecated functions in chrono#4189alamb merged 2 commits intoapache:masterfrom
alamb merged 2 commits intoapache:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #4187
Rationale for this change
Clippy failing on master
What changes are included in this PR?
Switch to use non deprecated functions (that don't panic internally). Will note the actual code changes
Are these changes tested?
covered in existing tests
Are there any user-facing changes?
Some better error messages when timestamp conversion fails