Add Aggregate::try new with validation checks#3286
Merged
andygrove merged 4 commits intoapache:masterfrom Aug 31, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #3285
Rationale for this change
I found a bug in
ProjectionPushDownin another branch I am working on. Adding validation checks when we create aggregate plans exposes this and seems like a good idea in general.What changes are included in this PR?
Add
Aggregate::try newand update existing code to call that rather than creating the struct directly.Are there any user-facing changes?
No