Skip to content

[branch-52] fix: Return probe_side.len() for RightMark/Anti count(*) queries (#20710)#20881

Merged
comphead merged 1 commit intoapache:branch-52from
alamb:alamb/backport_20710
Mar 12, 2026
Merged

[branch-52] fix: Return probe_side.len() for RightMark/Anti count(*) queries (#20710)#20881
comphead merged 1 commit intoapache:branch-52from
alamb:alamb/backport_20710

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Mar 11, 2026

…pache#20710)

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Closes apache#20669 .

Return probe_side.len() for count(*) queries
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

slt tests
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) physical-plan Changes to the physical-plan crate labels Mar 11, 2026
Copy link
Contributor

@jonathanc-n jonathanc-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alamb
Copy link
Contributor Author

alamb commented Mar 12, 2026

@comphead can I request an approval for this backport given you approved the original PR as well?

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@comphead comphead merged commit 41acbf8 into apache:branch-52 Mar 12, 2026
32 checks passed
lukekim pushed a commit to spiceai/datafusion that referenced this pull request Mar 12, 2026
…) queries (apache#20710) (apache#20881)

- Part of apache#20855
- Closes apache#20669 on branch-52

This PR:
- Backports apache#20710 from
@jonathanc-n to the branch-52 line

Co-authored-by: Jonathan Chen <chenleejonathan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants