fix: interval analysis error when have two filterexec that inner filter proves zero selectivity#20743
Merged
alamb merged 3 commits intoapache:mainfrom Mar 10, 2026
Merged
Conversation
…es zero selectirity
haohuaijin
changed the title
jonathanc-n
approved these changes
Mar 6, 2026
Contributor
jonathanc-n
left a comment
jonathanc-n
left a comment
There was a problem hiding this comment.
Very nice, makes sense to me!
hengfeiyang
approved these changes
Mar 10, 2026
alamb
changed the title
alamb
approved these changes
Mar 10, 2026
Contributor
There was a problem hiding this comment.
Thanks @haohuaijin and @jonathanc-n and @hengfeiyang
Contributor
Author
|
thanks @jonathanc-n @hengfeiyang @alamb for reviews |
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Mar 11, 2026
…er proves zero selectivity (apache#20743) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#20742 ## Rationale for this change - see apache#20742 ## What changes are included in this PR? In `collect_new_statistics`, when a filter proves no rows can match, use a typed null (e.g., ScalarValue::Int32(None)) instead of untyped ScalarValue::Null for column min/max/sum values. The column's data type is looked up from the schema so that downstream interval analysis can still intersect intervals of the same type. ## Are these changes tested? add one test case ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Mar 11, 2026
…er proves zero selectivity (apache#20743) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#20742 ## Rationale for this change - see apache#20742 ## What changes are included in this PR? In `collect_new_statistics`, when a filter proves no rows can match, use a typed null (e.g., ScalarValue::Int32(None)) instead of untyped ScalarValue::Null for column min/max/sum values. The column's data type is looked up from the schema so that downstream interval analysis can still intersect intervals of the same type. ## Are these changes tested? add one test case ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
alamb
added a commit
that referenced
this pull request
Mar 12, 2026
…t inner filter proves zero selectivity (#20743) (#20880) - Part of #20855 - Closes #20742 on branch-52 This PR: - Backports #20743 from @haohuaijin to the branch-52 line Co-authored-by: Huaijin <[email protected]>
alamb
added a commit
that referenced
this pull request
Mar 12, 2026
…t inner filter proves zero selectivity (#20743) (#20882) - Part of #19692 - Closes #20742 on branch-53 This PR: - Backports #20743 from @haohuaijin to the branch-53 line Co-authored-by: Huaijin <[email protected]>
lukekim
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Mar 12, 2026
…t inner filter proves zero selectivity (apache#20743) (apache#20880) - Part of apache#20855 - Closes apache#20742 on branch-52 This PR: - Backports apache#20743 from @haohuaijin to the branch-52 line Co-authored-by: Huaijin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
In
collect_new_statistics, when a filter proves no rows can match, use a typed null (e.g., ScalarValue::Int32(None)) instead of untyped ScalarValue::Null for column min/max/sum values. The column's data type is looked up from the schema so that downstream interval analysis can still intersect intervals of the same type.Are these changes tested?
add one test case
Are there any user-facing changes?