fix: disable dynamic filter pushdown for non min/max aggregates#20279
Merged
adriangb merged 6 commits intoapache:mainfrom Feb 12, 2026
Merged
fix: disable dynamic filter pushdown for non min/max aggregates#20279adriangb merged 6 commits intoapache:mainfrom
adriangb merged 6 commits intoapache:mainfrom
Conversation
adriangb
reviewed
Feb 10, 2026
adriangb
reviewed
Feb 10, 2026
adriangb
reviewed
Feb 11, 2026
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
Contributor
|
@notashes can we add a test? Ideally an SLT test in |
…th non min/max aggregates
adriangb
approved these changes
Feb 11, 2026
Contributor
adriangb
left a comment
adriangb
left a comment
There was a problem hiding this comment.
One of the new tests likely duplicates existing ones - otherwise LGTM!
|
|
||
| # Test 4b: Mixed aggregates with non MIN/MAX should not have DynamicFilter | ||
|
|
||
| # Pure MAX — DynamicFilter is expected here as we can safely prune that don't match the filter. |
Contributor
There was a problem hiding this comment.
I think there is already a test for this
Contributor
Author
There was a problem hiding this comment.
removed that one! thanks!
Contributor
|
I plan to merge this once CI passes 😄 |
2 tasks
erratic-pattern
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Mar 9, 2026
…he#20279) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Partially closes apache#20267 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Currently whenever we get a query with `min` or `max` we default to always pushing down the dynamic filter (when it's enabled). However if the query contains other aggregate functions such as `sum`, `avg` they require the full batch of rows. And because of the pruned rows we receive incorrect outputs for the query. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> return the `init_dynamic_filter()` early if it contains non min/max aggregates. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Tested locally for the same query mentioned in the issue with `hits_partitioned` and got the correct output. Will add the tests! ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
erratic-pattern
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Mar 9, 2026
…he#20279) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Partially closes apache#20267 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Currently whenever we get a query with `min` or `max` we default to always pushing down the dynamic filter (when it's enabled). However if the query contains other aggregate functions such as `sum`, `avg` they require the full batch of rows. And because of the pruned rows we receive incorrect outputs for the query. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> return the `init_dynamic_filter()` early if it contains non min/max aggregates. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Tested locally for the same query mentioned in the issue with `hits_partitioned` and got the correct output. Will add the tests! ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
12 tasks
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Mar 11, 2026
…he#20279) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Partially closes apache#20267 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Currently whenever we get a query with `min` or `max` we default to always pushing down the dynamic filter (when it's enabled). However if the query contains other aggregate functions such as `sum`, `avg` they require the full batch of rows. And because of the pruned rows we receive incorrect outputs for the query. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> return the `init_dynamic_filter()` early if it contains non min/max aggregates. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Tested locally for the same query mentioned in the issue with `hits_partitioned` and got the correct output. Will add the tests! ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
lukekim
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Mar 12, 2026
…egates (apache#20279) (apache#20877) - Part of apache#20855 - Closes apache#20267 on branch-52 This PR: - Backports apache#20279 from @notashes to the branch-52 line Co-authored-by: notashes <edgerunnergit@riseup.net> Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Currently whenever we get a query with
minormaxwe default to always pushing down the dynamic filter (when it's enabled). However if the query contains other aggregate functions such assum,avgthey require the full batch of rows. And because of the pruned rows we receive incorrect outputs for the query.What changes are included in this PR?
return the
init_dynamic_filter()early if it contains non min/max aggregates.Are these changes tested?
Tested locally for the same query mentioned in the issue with
hits_partitionedand got the correct output. Will add the tests!Are there any user-facing changes?