Improve HashJoinExecBuilder to save state from previous fields#20276
Merged
alamb merged 4 commits intoapache:mainfrom Feb 24, 2026
Merged
Improve HashJoinExecBuilder to save state from previous fields#20276alamb merged 4 commits intoapache:mainfrom
HashJoinExecBuilder to save state from previous fields#20276alamb merged 4 commits intoapache:mainfrom
Conversation
github-actions
bot
added
optimizer
askalt
force-pushed
the
askalt/improve-hash-join-exec-builder
branch
from
fbc498f to
dcc9cfa
Compare
jonathanc-n
reviewed
Feb 12, 2026
Contributor
jonathanc-n
left a comment
jonathanc-n
left a comment
There was a problem hiding this comment.
I left a comment, but this is a nicely designed. Thanks!
jonathanc-n
reviewed
Feb 12, 2026
alamb
changed the title
HashJoinExecBuilder to save state from previous fields
alamb
approved these changes
Feb 13, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great to me -- thank you @askalt and @jonathanc-n
@2010YOUY01 what do you think about this?
| /// Builder can be created from an existing [`HashJoinExec`] using [`From::from`]. | ||
| /// In this case, all its fields are inherited. If a field that affects the node's | ||
| /// properties is modified, they will be automatically recomputed during the build. | ||
| pub struct HashJoinExecBuilder { |
Contributor
There was a problem hiding this comment.
A minor API suggestion to make this code more discoverable might be to add an explicit method to HashJoinExec such as into_builder (and leave the From impl as well )
Something like
let builder = hash_join_exec.into_builder()
Contributor
Author
There was a problem hiding this comment.
It seems typicaly into_* takes self, but here HashJoinExec is not clone (as I see from the comment it is done intentionally) so it is always never could be consumed. Added builder instead:
+ /// Create a builder based on the existing [`HashJoinExec`].
+ ///
+ /// Returned builder preserves all existing fields. If a field requiring properties
+ /// recomputation is modified, this will be done automatically during the node build.
+ ///
+ pub fn builder(&self) -> HashJoinExecBuilder {
+ self.into()
+ }
+
askalt
force-pushed
the
askalt/improve-hash-join-exec-builder
branch
from
dcc9cfa to
4347a27
Compare
Contributor
Author
|
Working on CI fix. |
Prior the patch HashJoinExecBuilder constructed from an existing node reseted some fields of the node, e.g. dynamic filters, metrics. It significantly reduces usage scope of the builder. This patch improves the implementation. Now builder created from the existing node preserves all fields in case they have not been explicitly updated. Also builder now tracks flag if it must recompute plan properties. Closes apache#20270
askalt
force-pushed
the
askalt/improve-hash-join-exec-builder
branch
from
4347a27 to
0f33f41
Compare
Contributor
|
I merged up to resolve a conflict |
Contributor
|
And again |
Contributor
|
🚀 thank you for the help @askalt @jonathanc-n |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #20270
Prior the patch HashJoinExecBuilder constructed from an existing node reseted some fields of the node, e.g. dynamic filters, metrics. It significantly reduces usage scope of the builder.
What changes are included in this PR?
This patch improves the implementation. Now builder created from the existing node preserves all fields in case they have not been explicitly updated. Also builder now tracks flag if it must recompute plan properties.