Skip to content

Minor: verify plan output and unique field names #20220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Feb 9, 2026
Merged

Minor: verify plan output and unique field names #20220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion datafusion/substrait/tests/cases/logical_plans.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
#[cfg(test)]
mod tests {
use crate::utils::test::{add_plan_schemas_to_ctx, read_json};
use datafusion::common::test_util::format_batches;
use std::collections::HashSet;

use datafusion::common::Result;
use datafusion::dataframe::DataFrame;
use datafusion::prelude::SessionContext;
Expand Down Expand Up @@ -250,7 +253,27 @@ mod tests {
);

// Trigger execution to ensure plan validity
DataFrame::new(ctx.state(), plan).show().await?;
let results = DataFrame::new(ctx.state(), plan).collect().await?;

assert_snapshot!(
format_batches(&results)?,
@r"
+------+------+
| col1 | col2 |
+------+------+
| 100 | 200 |
| 300 | 400 |
+------+------+
",
);

// also verify that the output schema has unique field names
let schema = results[0].schema();
for batch in &results {
assert_eq!(schema, batch.schema());
}
let field_names: HashSet<_> = schema.fields().iter().map(|f| f.name()).collect();
assert_eq!(field_names.len(), schema.fields().len());

Ok(())
}
Expand Down