fix: maintain inner list nullability for array_sort#19948
Merged
comphead merged 2 commits intoapache:mainfrom Jan 25, 2026
Merged
fix: maintain inner list nullability for array_sort#19948comphead merged 2 commits intoapache:mainfrom
array_sort#19948comphead merged 2 commits intoapache:mainfrom
Conversation
timsaucer
reviewed
Jan 23, 2026
Comment on lines
-145
to
-147
| arg_type => { | ||
| plan_err!("{} does not support type {arg_type}", self.name()) | ||
| } |
Member
There was a problem hiding this comment.
By removing this, don't we delay the error generated when someone passes an invalid type until execution? It seems like we want this check to still happen during planning.
Maybe something like match on DataType::Null | DataType::List(_) | ataType::LargeList(_) => Ok(arg_types[0].clone())
Contributor
Author
There was a problem hiding this comment.
The signature should already guard us from that path; it was only there for completeness before. Worst case if something does go wrong at least we'll just error normally at execution time instead of panicking via unreachable!() for example
timsaucer
approved these changes
Jan 24, 2026
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Mar 11, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes apache#19947 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> apache#17657 introduced a regression since it cloned the inner field in the execution path but in the `return_type` function it still set nullability to true. Fix to ensure we maintain the field of the inner field as is. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Change `return_type` to just pass through the input datatype as is. Also refactor away usage of a null buffer builder in favour of copying the input array null buffer. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Added tests. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No. <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
alamb
added a commit
that referenced
this pull request
Mar 12, 2026
lukekim
pushed a commit
to spiceai/datafusion
that referenced
this pull request
Mar 12, 2026
…pache#20878) - Part of apache#20855 - Closes apache#19947 on branch-52 This PR: - Backports apache#19948 from @Jefffrey to the branch-52 line Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
array_sortfails on list with inner non-nullable field #19947Rationale for this change
#17657 introduced a regression since it cloned the inner field in the execution path but in the
return_typefunction it still set nullability to true. Fix to ensure we maintain the field of the inner field as is.What changes are included in this PR?
Change
return_typeto just pass through the input datatype as is.Also refactor away usage of a null buffer builder in favour of copying the input array null buffer.
Are these changes tested?
Added tests.
Are there any user-facing changes?
No.