Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Dec 24, 2025

Which issue does this PR close?

Rationale for this change

I am testing where we currently are with performance

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@alamb
Copy link
Contributor Author

alamb commented Dec 24, 2025

run benchmarks

@github-actions github-actions bot added the common Related to common crate label Dec 24, 2025
@alamb-ghbot
Copy link

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (36eae88) to 67b526a diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

@alamb-ghbot
Copy link

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ alamb_enable_pushdown ┃         Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0     │  2685.93 ms │            2651.31 ms │      no change │
│ QQuery 1     │  1073.38 ms │            1053.67 ms │      no change │
│ QQuery 2     │  2088.87 ms │            2076.62 ms │      no change │
│ QQuery 3     │  1135.31 ms │            1169.33 ms │      no change │
│ QQuery 4     │  2311.12 ms │            2333.31 ms │      no change │
│ QQuery 5     │ 28540.84 ms │           29180.44 ms │      no change │
│ QQuery 6     │  4022.77 ms │             231.17 ms │ +17.40x faster │
│ QQuery 7     │  3930.66 ms │            4171.90 ms │   1.06x slower │
└──────────────┴─────────────┴───────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 45788.88ms │
│ Total Time (alamb_enable_pushdown)   │ 42867.76ms │
│ Average Time (HEAD)                  │  5723.61ms │
│ Average Time (alamb_enable_pushdown) │  5358.47ms │
│ Queries Faster                       │          1 │
│ Queries Slower                       │          1 │
│ Queries with No Change               │          6 │
│ Queries with Failure                 │          0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ alamb_enable_pushdown ┃         Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.37 ms │               2.13 ms │  +1.12x faster │
│ QQuery 1     │    50.16 ms │              52.79 ms │   1.05x slower │
│ QQuery 2     │   134.81 ms │             131.30 ms │      no change │
│ QQuery 3     │   154.45 ms │             154.20 ms │      no change │
│ QQuery 4     │  1137.52 ms │            1117.24 ms │      no change │
│ QQuery 5     │  1511.93 ms │            1476.79 ms │      no change │
│ QQuery 6     │     2.04 ms │               2.02 ms │      no change │
│ QQuery 7     │    59.58 ms │              68.59 ms │   1.15x slower │
│ QQuery 8     │  1474.01 ms │            1456.40 ms │      no change │
│ QQuery 9     │  1854.79 ms │            1834.23 ms │      no change │
│ QQuery 10    │   353.18 ms │             492.42 ms │   1.39x slower │
│ QQuery 11    │   402.12 ms │             525.34 ms │   1.31x slower │
│ QQuery 12    │  1356.90 ms │            1555.24 ms │   1.15x slower │
│ QQuery 13    │  2021.01 ms │            2244.56 ms │   1.11x slower │
│ QQuery 14    │  1244.62 ms │            1454.12 ms │   1.17x slower │
│ QQuery 15    │  1274.32 ms │            1277.69 ms │      no change │
│ QQuery 16    │  2636.20 ms │            2571.86 ms │      no change │
│ QQuery 17    │  2601.62 ms │            2559.34 ms │      no change │
│ QQuery 18    │  5918.57 ms │            4875.16 ms │  +1.21x faster │
│ QQuery 19    │   130.29 ms │             141.55 ms │   1.09x slower │
│ QQuery 20    │  1929.33 ms │            1857.46 ms │      no change │
│ QQuery 21    │  2200.83 ms │            2330.91 ms │   1.06x slower │
│ QQuery 22    │  3857.11 ms │            3729.31 ms │      no change │
│ QQuery 23    │ 20156.62 ms │            1283.72 ms │ +15.70x faster │
│ QQuery 24    │   221.23 ms │             283.74 ms │   1.28x slower │
│ QQuery 25    │   474.00 ms │             628.50 ms │   1.33x slower │
│ QQuery 26    │   216.46 ms │             340.81 ms │   1.57x slower │
│ QQuery 27    │  2762.90 ms │            2961.52 ms │   1.07x slower │
│ QQuery 28    │ 23671.71 ms │           23963.73 ms │      no change │
│ QQuery 29    │   970.01 ms │             952.03 ms │      no change │
│ QQuery 30    │  1327.99 ms │            1342.13 ms │      no change │
│ QQuery 31    │  1345.31 ms │            1348.15 ms │      no change │
│ QQuery 32    │  5652.98 ms │            4588.56 ms │  +1.23x faster │
│ QQuery 33    │  6275.28 ms │            5666.71 ms │  +1.11x faster │
│ QQuery 34    │  6526.66 ms │            5968.31 ms │  +1.09x faster │
│ QQuery 35    │  1983.97 ms │            1908.53 ms │      no change │
│ QQuery 36    │    66.42 ms │              15.94 ms │  +4.17x faster │
│ QQuery 37    │    45.91 ms │              16.16 ms │  +2.84x faster │
│ QQuery 38    │    65.21 ms │              15.26 ms │  +4.27x faster │
│ QQuery 39    │   105.50 ms │              14.18 ms │  +7.44x faster │
│ QQuery 40    │    27.96 ms │              16.61 ms │  +1.68x faster │
│ QQuery 41    │    22.42 ms │              14.93 ms │  +1.50x faster │
│ QQuery 42    │    19.97 ms │              14.33 ms │  +1.39x faster │
└──────────────┴─────────────┴───────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃             ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 104246.25ms │
│ Total Time (alamb_enable_pushdown)   │  83254.49ms │
│ Average Time (HEAD)                  │   2424.33ms │
│ Average Time (alamb_enable_pushdown) │   1936.15ms │
│ Queries Faster                       │          13 │
│ Queries Slower                       │          13 │
│ Queries with No Change               │          17 │
│ Queries with Failure                 │           0 │
└──────────────────────────────────────┴─────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ alamb_enable_pushdown ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 115.22 ms │             114.68 ms │     no change │
│ QQuery 2     │  29.72 ms │              29.81 ms │     no change │
│ QQuery 3     │  39.93 ms │              38.86 ms │     no change │
│ QQuery 4     │  29.27 ms │              29.63 ms │     no change │
│ QQuery 5     │  90.54 ms │              89.69 ms │     no change │
│ QQuery 6     │  19.67 ms │              19.94 ms │     no change │
│ QQuery 7     │ 252.26 ms │             242.01 ms │     no change │
│ QQuery 8     │  38.03 ms │              39.72 ms │     no change │
│ QQuery 9     │ 105.70 ms │             103.01 ms │     no change │
│ QQuery 10    │  63.88 ms │              61.48 ms │     no change │
│ QQuery 11    │  19.33 ms │              18.03 ms │ +1.07x faster │
│ QQuery 12    │  51.68 ms │              53.21 ms │     no change │
│ QQuery 13    │  47.99 ms │              51.36 ms │  1.07x slower │
│ QQuery 14    │  14.31 ms │              14.02 ms │     no change │
│ QQuery 15    │  24.23 ms │              24.83 ms │     no change │
│ QQuery 16    │  24.31 ms │              25.01 ms │     no change │
│ QQuery 17    │ 152.94 ms │             155.39 ms │     no change │
│ QQuery 18    │ 292.03 ms │             310.42 ms │  1.06x slower │
│ QQuery 19    │  37.18 ms │              38.00 ms │     no change │
│ QQuery 20    │  49.54 ms │              51.51 ms │     no change │
│ QQuery 21    │ 333.15 ms │             350.45 ms │  1.05x slower │
│ QQuery 22    │  17.68 ms │              17.40 ms │     no change │
└──────────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                    ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                    │ 1848.58ms │
│ Total Time (alamb_enable_pushdown)   │ 1878.46ms │
│ Average Time (HEAD)                  │   84.03ms │
│ Average Time (alamb_enable_pushdown) │   85.38ms │
│ Queries Faster                       │         1 │
│ Queries Slower                       │         3 │
│ Queries with No Change               │        18 │
│ Queries with Failure                 │         0 │
└──────────────────────────────────────┴───────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants