Simplify Spark sha2 implementation
#19475
Open
+147
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
Jefffrey
commented
Dec 24, 2025
Comment on lines
-49
to
+63
| signature: Signature::user_defined(Volatility::Immutable), | ||
| aliases: vec![], | ||
| signature: Signature::coercible( | ||
| vec![ | ||
| Coercion::new_implicit( | ||
| TypeSignatureClass::Native(logical_binary()), | ||
| vec![TypeSignatureClass::Native(logical_string())], | ||
| NativeType::Binary, | ||
| ), | ||
| Coercion::new_implicit( | ||
| TypeSignatureClass::Native(logical_int32()), | ||
| vec![TypeSignatureClass::Integer], | ||
| NativeType::Int32, |
Contributor
Author
There was a problem hiding this comment.
Moving away from user_defined; also we cast strings to binary to simplify implementation as we only need raw bytes either way
Comment on lines
+121
to
+134
| let mut digest = sha2::Sha224::default(); | ||
| digest.update(value); | ||
| Some(hex_encode(digest.finalize())) | ||
| } | ||
| (Some(value), Some(0 | 256)) => { | ||
| let mut digest = sha2::Sha256::default(); | ||
| digest.update(value); | ||
| Some(hex_encode(digest.finalize())) | ||
| } | ||
| (Some(value), Some(384)) => { | ||
| let mut digest = sha2::Sha384::default(); | ||
| digest.update(value); | ||
| Some(hex_encode(digest.finalize())) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We directly use the sha2 crate to do the hashing now; previously we used functions exposed by datafusion-functions but that seemed like unnecessary indirection
| regex = "1.12" | ||
| rstest = "0.26.1" | ||
| serde_json = "1" | ||
| sha2 = "^0.10.9" |
Contributor
Author
There was a problem hiding this comment.
Because datafusion-spark now uses sha2 directly, we extract it as a common dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Signature::user_definedfor normal functions #12725Rationale for this change
Simplify implementation, also remove usage of user_defined.
What changes are included in this PR?
Refactor to be simpler.
Are these changes tested?
Added tests.
Are there any user-facing changes?
No.