perf: skip double lookup in multi group by hash map #19430

rluvaton · 2025-12-20T21:58:53Z

Which issue does this PR close?

N/A

Rationale for this change

Making DataFusion faster.

the insert_accounted first find the entry (without increasing the capacity) and if missing insert using entry().insert() which search again the entry from what I understand. so avoided using insert_accounted and always use entry and insert of missing which will prepare for insert if the table doesn't have enough space

What changes are included in this PR?

remove usages of insert_accounted on hashbrown::HashTable with entry() and insert if missing
added allocated_size to hashbrown::HashTable
remove map_size and calculate it on call to size as it is very cheap

Are these changes tested?

Existing tests

Are there any user-facing changes?

added allocated_size similar to allocated_size for Vec that we added.

from my local tests, it showed good perf improvements

rluvaton · 2025-12-20T21:59:55Z

run benchmark aggregate_query_sql

alamb-ghbot · 2025-12-20T22:00:00Z

🤖 ./gh_compare_branch_bench.sh compare_branch_bench.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve-performance-by-avoiding-double-search (936bd9a) to d8e68a4 diff
BENCH_NAME=aggregate_query_sql
BENCH_COMMAND=cargo bench --features=parquet --bench aggregate_query_sql
BENCH_FILTER=
BENCH_BRANCH_NAME=improve-performance-by-avoiding-double-search
Results will be posted here when complete

alamb-ghbot · 2025-12-20T22:32:42Z

🤖: Benchmark completed

Details

group                                                                         improve-performance-by-avoiding-double-search    main
-----                                                                         ---------------------------------------------    ----
aggregate_query_approx_percentile_cont_on_f32                                 1.00      3.8±0.18ms        ? ?/sec              1.03      3.9±0.19ms        ? ?/sec
aggregate_query_approx_percentile_cont_on_u64                                 1.00      4.1±0.22ms        ? ?/sec              1.02      4.2±0.20ms        ? ?/sec
aggregate_query_distinct_median                                               1.00      2.7±0.04ms        ? ?/sec              1.00      2.7±0.03ms        ? ?/sec
aggregate_query_group_by                                                      1.00  1563.0±34.33µs        ? ?/sec              1.00  1559.6±49.01µs        ? ?/sec
aggregate_query_group_by_u64 15 12                                            1.00  1479.7±39.63µs        ? ?/sec              1.00  1484.0±29.04µs        ? ?/sec
aggregate_query_group_by_u64_multiple_keys                                    1.00      4.0±0.23ms        ? ?/sec              1.04      4.2±0.24ms        ? ?/sec
aggregate_query_group_by_wide_u64_and_f32_without_aggregate_expressions       1.00      2.1±0.07ms        ? ?/sec              1.07      2.2±0.12ms        ? ?/sec
aggregate_query_group_by_wide_u64_and_string_without_aggregate_expressions    1.00      2.5±0.15ms        ? ?/sec              1.05      2.7±0.16ms        ? ?/sec
aggregate_query_group_by_with_filter                                          1.00  1422.0±25.98µs        ? ?/sec              1.00  1427.9±17.72µs        ? ?/sec
aggregate_query_group_by_with_filter_u64 15 12                                1.00  1389.1±18.87µs        ? ?/sec              1.01  1401.7±27.64µs        ? ?/sec
aggregate_query_no_group_by 15 12                                             1.00    733.2±9.70µs        ? ?/sec              1.00   733.2±20.36µs        ? ?/sec
aggregate_query_no_group_by_count_distinct_narrow                             1.00  1163.7±19.54µs        ? ?/sec              1.00  1159.8±18.76µs        ? ?/sec
aggregate_query_no_group_by_count_distinct_wide                               1.01  1978.7±87.09µs        ? ?/sec              1.00  1968.6±82.71µs        ? ?/sec
aggregate_query_no_group_by_min_max_f64                                       1.00    686.4±8.64µs        ? ?/sec              1.00    684.6±6.69µs        ? ?/sec
first_last_ignore_nulls                                                       1.00      2.2±0.09ms        ? ?/sec              1.00      2.2±0.08ms        ? ?/sec
first_last_many_columns                                                       1.00      2.2±0.10ms        ? ?/sec              1.00      2.2±0.08ms        ? ?/sec
first_last_one_column                                                         1.00  1898.1±92.35µs        ? ?/sec              1.00  1891.4±56.63µs        ? ?/sec

Dandandan · 2025-12-21T12:44:10Z

run benchmarks

Dandandan · 2025-12-21T12:44:27Z

run benchmark tpch tpcds

alamb · 2025-12-21T14:10:14Z

run benchmark tpch tpcds

alamb · 2025-12-21T14:10:24Z

(the script was having problems)

alamb · 2025-12-21T14:10:30Z

run benchmarks

alamb-ghbot · 2025-12-21T14:59:43Z

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve-performance-by-avoiding-double-search (936bd9a) to d8e68a4 diff using: tpch
Results will be posted here when complete

alamb-ghbot · 2025-12-21T15:14:41Z

🤖: Benchmark completed

Details

Comparing HEAD and improve-performance-by-avoiding-double-search
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ improve-performance-by-avoiding-double-search ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 192.88 ms │                                     188.44 ms │     no change │
│ QQuery 2     │ 101.78 ms │                                      95.84 ms │ +1.06x faster │
│ QQuery 3     │ 138.93 ms │                                     129.51 ms │ +1.07x faster │
│ QQuery 4     │  76.79 ms │                                      76.39 ms │     no change │
│ QQuery 5     │ 178.19 ms │                                     176.45 ms │     no change │
│ QQuery 6     │  64.87 ms │                                      67.42 ms │     no change │
│ QQuery 7     │ 212.55 ms │                                     214.81 ms │     no change │
│ QQuery 8     │ 165.84 ms │                                     163.91 ms │     no change │
│ QQuery 9     │ 227.99 ms │                                     219.65 ms │     no change │
│ QQuery 10    │ 181.77 ms │                                     189.85 ms │     no change │
│ QQuery 11    │  77.19 ms │                                      75.58 ms │     no change │
│ QQuery 12    │ 113.77 ms │                                     115.89 ms │     no change │
│ QQuery 13    │ 228.00 ms │                                     219.62 ms │     no change │
│ QQuery 14    │  91.71 ms │                                      96.33 ms │  1.05x slower │
│ QQuery 15    │ 117.57 ms │                                     126.74 ms │  1.08x slower │
│ QQuery 16    │  56.45 ms │                                      57.01 ms │     no change │
│ QQuery 17    │ 269.68 ms │                                     278.43 ms │     no change │
│ QQuery 18    │ 321.81 ms │                                     318.42 ms │     no change │
│ QQuery 19    │ 137.57 ms │                                     137.53 ms │     no change │
│ QQuery 20    │ 124.29 ms │                                     126.36 ms │     no change │
│ QQuery 21    │ 261.14 ms │                                     264.14 ms │     no change │
│ QQuery 22    │  42.33 ms │                                      42.57 ms │     no change │
└──────────────┴───────────┴───────────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                                            ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                                            │ 3383.10ms │
│ Total Time (improve-performance-by-avoiding-double-search)   │ 3380.91ms │
│ Average Time (HEAD)                                          │  153.78ms │
│ Average Time (improve-performance-by-avoiding-double-search) │  153.68ms │
│ Queries Faster                                               │         2 │
│ Queries Slower                                               │         2 │
│ Queries with No Change                                       │        18 │
│ Queries with Failure                                         │         0 │
└──────────────────────────────────────────────────────────────┴───────────┘

alamb-ghbot · 2025-12-21T15:14:43Z

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve-performance-by-avoiding-double-search (936bd9a) to d8e68a4 diff using: tpcds
Results will be posted here when complete

alamb-ghbot · 2025-12-21T15:23:27Z

🤖: Benchmark completed

Details

Comparing HEAD and improve-performance-by-avoiding-double-search
--------------------
Benchmark tpcds_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ improve-performance-by-avoiding-double-search ┃       Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1     │    61.06 ms │                                      60.71 ms │    no change │
│ QQuery 2     │   206.52 ms │                                     204.82 ms │    no change │
│ QQuery 3     │   155.54 ms │                                     154.81 ms │    no change │
│ QQuery 4     │  1909.99 ms │                                    1885.82 ms │    no change │
│ QQuery 5     │   253.92 ms │                                     260.49 ms │    no change │
│ QQuery 6     │  1530.25 ms │                                    1570.45 ms │    no change │
│ QQuery 7     │   494.89 ms │                                     481.55 ms │    no change │
│ QQuery 8     │   164.48 ms │                                     162.44 ms │    no change │
│ QQuery 9     │   260.40 ms │                                     267.37 ms │    no change │
│ QQuery 10    │   167.32 ms │                                     160.73 ms │    no change │
│ QQuery 11    │  1300.97 ms │                                    1299.67 ms │    no change │
│ QQuery 12    │    67.73 ms │                                      72.08 ms │ 1.06x slower │
│ QQuery 13    │   537.23 ms │                                     531.77 ms │    no change │
│ QQuery 14    │  1962.98 ms │                                    1929.49 ms │    no change │
│ QQuery 15    │    26.95 ms │                                      28.25 ms │    no change │
│ QQuery 16    │    56.02 ms │                                      57.27 ms │    no change │
│ QQuery 17    │   351.69 ms │                                     354.26 ms │    no change │
│ QQuery 18    │   187.18 ms │                                     187.68 ms │    no change │
│ QQuery 19    │   218.47 ms │                                     224.40 ms │    no change │
│ QQuery 20    │    22.16 ms │                                      22.65 ms │    no change │
│ QQuery 21    │    34.29 ms │                                      33.65 ms │    no change │
│ QQuery 22    │   788.70 ms │                                     808.77 ms │    no change │
│ QQuery 23    │  1851.97 ms │                                    1833.80 ms │    no change │
│ QQuery 24    │   619.44 ms │                                     622.83 ms │    no change │
│ QQuery 25    │   504.61 ms │                                     502.67 ms │    no change │
│ QQuery 26    │   124.40 ms │                                     121.18 ms │    no change │
│ QQuery 27    │   484.22 ms │                                     484.41 ms │    no change │
│ QQuery 28    │   291.06 ms │                                     289.24 ms │    no change │
│ QQuery 29    │   431.67 ms │                                     438.99 ms │    no change │
│ QQuery 30    │    60.23 ms │                                      61.66 ms │    no change │
│ QQuery 31    │   284.76 ms │                                     294.55 ms │    no change │
│ QQuery 32    │    75.68 ms │                                      76.47 ms │    no change │
│ QQuery 33    │   187.96 ms │                                     185.87 ms │    no change │
│ QQuery 34    │   157.21 ms │                                     159.66 ms │    no change │
│ QQuery 35    │   162.86 ms │                                     166.35 ms │    no change │
│ QQuery 36    │   293.87 ms │                                     292.55 ms │    no change │
│ QQuery 37    │   254.80 ms │                                     259.53 ms │    no change │
│ QQuery 38    │   140.90 ms │                                     142.45 ms │    no change │
│ QQuery 39    │   207.76 ms │                                     214.30 ms │    no change │
│ QQuery 40    │   187.03 ms │                                     193.48 ms │    no change │
│ QQuery 41    │    16.70 ms │                                      17.03 ms │    no change │
│ QQuery 42    │   137.19 ms │                                     138.47 ms │    no change │
│ QQuery 43    │   120.00 ms │                                     122.26 ms │    no change │
│ QQuery 44    │    15.71 ms │                                      15.39 ms │    no change │
│ QQuery 45    │    82.13 ms │                                      80.77 ms │    no change │
│ QQuery 46    │   315.56 ms │                                     326.01 ms │    no change │
│ QQuery 47    │  1125.17 ms │                                    1194.54 ms │ 1.06x slower │
│ QQuery 48    │   416.73 ms │                                     416.10 ms │    no change │
│ QQuery 49    │   347.98 ms │                                     343.54 ms │    no change │
│ QQuery 50    │   336.81 ms │                                     340.41 ms │    no change │
│ QQuery 51    │   293.82 ms │                                     294.51 ms │    no change │
│ QQuery 52    │   137.46 ms │                                     139.04 ms │    no change │
│ QQuery 53    │   144.89 ms │                                     147.54 ms │    no change │
│ QQuery 54    │   208.06 ms │                                     210.18 ms │    no change │
│ QQuery 55    │   138.01 ms │                                     140.32 ms │    no change │
│ QQuery 56    │   185.93 ms │                                     188.14 ms │    no change │
│ QQuery 57    │   284.81 ms │                                     289.83 ms │    no change │
│ QQuery 58    │   500.13 ms │                                     504.70 ms │    no change │
│ QQuery 59    │   290.45 ms │                                     299.60 ms │    no change │
│ QQuery 60    │   190.76 ms │                                     192.78 ms │    no change │
│ QQuery 61    │   228.18 ms │                                     231.12 ms │    no change │
│ QQuery 62    │  1333.39 ms │                                    1365.94 ms │    no change │
│ QQuery 63    │   147.96 ms │                                     148.77 ms │    no change │
│ QQuery 64    │  1128.71 ms │                                    1146.47 ms │    no change │
│ QQuery 65    │   343.40 ms │                                     351.86 ms │    no change │
│ QQuery 66    │   383.38 ms │                                     392.01 ms │    no change │
│ QQuery 67    │   559.02 ms │                                     559.54 ms │    no change │
│ QQuery 68    │   364.06 ms │                                     367.81 ms │    no change │
│ QQuery 69    │   158.47 ms │                                     163.37 ms │    no change │
│ QQuery 70    │   491.43 ms │                                     497.79 ms │    no change │
│ QQuery 71    │   177.70 ms │                                     180.48 ms │    no change │
│ QQuery 72    │  2484.24 ms │                                    2516.74 ms │    no change │
│ QQuery 73    │   151.51 ms │                                     155.10 ms │    no change │
│ QQuery 74    │   817.48 ms │                                     837.02 ms │    no change │
│ QQuery 75    │   393.48 ms │                                     379.52 ms │    no change │
│ QQuery 76    │   180.16 ms │                                     178.80 ms │    no change │
│ QQuery 77    │   258.95 ms │                                     254.47 ms │    no change │
│ QQuery 78    │   926.57 ms │                                     910.67 ms │    no change │
│ QQuery 79    │   322.27 ms │                                     324.09 ms │    no change │
│ QQuery 80    │   483.94 ms │                                     489.02 ms │    no change │
│ QQuery 81    │    41.13 ms │                                      39.74 ms │    no change │
│ QQuery 82    │   294.60 ms │                                     294.17 ms │    no change │
│ QQuery 83    │    67.43 ms │                                      69.85 ms │    no change │
│ QQuery 84    │    62.68 ms │                                      62.21 ms │    no change │
│ QQuery 85    │   220.12 ms │                                     220.21 ms │    no change │
│ QQuery 86    │    56.51 ms │                                      55.14 ms │    no change │
│ QQuery 87    │   145.71 ms │                                     142.14 ms │    no change │
│ QQuery 88    │   239.59 ms │                                     235.29 ms │    no change │
│ QQuery 89    │   163.21 ms │                                     166.07 ms │    no change │
│ QQuery 90    │    35.81 ms │                                      36.07 ms │    no change │
│ QQuery 91    │    93.75 ms │                                      92.26 ms │    no change │
│ QQuery 92    │    75.53 ms │                                      76.28 ms │    no change │
│ QQuery 93    │   262.34 ms │                                     260.30 ms │    no change │
│ QQuery 94    │    84.15 ms │                                      82.37 ms │    no change │
│ QQuery 95    │   256.17 ms │                                     256.04 ms │    no change │
│ QQuery 96    │   109.12 ms │                                     110.06 ms │    no change │
│ QQuery 97    │   180.03 ms │                                     178.86 ms │    no change │
│ QQuery 98    │   228.66 ms │                                     230.20 ms │    no change │
│ QQuery 99    │ 14896.90 ms │                                   14910.84 ms │    no change │
└──────────────┴─────────────┴───────────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                                            ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                                            │ 51215.19ms │
│ Total Time (improve-performance-by-avoiding-double-search)   │ 51469.00ms │
│ Average Time (HEAD)                                          │   517.33ms │
│ Average Time (improve-performance-by-avoiding-double-search) │   519.89ms │
│ Queries Faster                                               │          0 │
│ Queries Slower                                               │          2 │
│ Queries with No Change                                       │         97 │
│ Queries with Failure                                         │          0 │
└──────────────────────────────────────────────────────────────┴────────────┘

alamb-ghbot · 2025-12-21T15:23:29Z

🤖 ./gh_compare_branch.sh gh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing improve-performance-by-avoiding-double-search (936bd9a) to d8e68a4 diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

alamb-ghbot · 2025-12-21T15:48:38Z

🤖: Benchmark completed

Details

Comparing HEAD and improve-performance-by-avoiding-double-search
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ improve-performance-by-avoiding-double-search ┃       Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 0     │  2616.42 ms │                                    2651.47 ms │    no change │
│ QQuery 1     │  1061.28 ms │                                    1066.18 ms │    no change │
│ QQuery 2     │  2039.21 ms │                                    2149.76 ms │ 1.05x slower │
│ QQuery 3     │  1194.67 ms │                                    1218.22 ms │    no change │
│ QQuery 4     │  2300.33 ms │                                    2276.93 ms │    no change │
│ QQuery 5     │ 28972.86 ms │                                   29093.73 ms │    no change │
│ QQuery 6     │  3873.07 ms │                                    3860.04 ms │    no change │
│ QQuery 7     │  3816.73 ms │                                    3648.43 ms │    no change │
└──────────────┴─────────────┴───────────────────────────────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                                            ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                                            │ 45874.56ms │
│ Total Time (improve-performance-by-avoiding-double-search)   │ 45964.76ms │
│ Average Time (HEAD)                                          │  5734.32ms │
│ Average Time (improve-performance-by-avoiding-double-search) │  5745.59ms │
│ Queries Faster                                               │          0 │
│ Queries Slower                                               │          1 │
│ Queries with No Change                                       │          7 │
│ Queries with Failure                                         │          0 │
└──────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃        HEAD ┃ improve-performance-by-avoiding-double-search ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0     │     2.22 ms │                                       2.17 ms │     no change │
│ QQuery 1     │    48.89 ms │                                      48.91 ms │     no change │
│ QQuery 2     │   132.59 ms │                                     131.20 ms │     no change │
│ QQuery 3     │   155.28 ms │                                     156.99 ms │     no change │
│ QQuery 4     │  1114.63 ms │                                    1109.74 ms │     no change │
│ QQuery 5     │  1436.94 ms │                                    1474.80 ms │     no change │
│ QQuery 6     │     2.05 ms │                                       2.05 ms │     no change │
│ QQuery 7     │    54.29 ms │                                      56.08 ms │     no change │
│ QQuery 8     │  1434.72 ms │                                    1446.35 ms │     no change │
│ QQuery 9     │  1804.58 ms │                                    1818.81 ms │     no change │
│ QQuery 10    │   346.48 ms │                                     347.23 ms │     no change │
│ QQuery 11    │   403.67 ms │                                     394.99 ms │     no change │
│ QQuery 12    │  1319.87 ms │                                    1367.56 ms │     no change │
│ QQuery 13    │  1951.07 ms │                                    2041.60 ms │     no change │
│ QQuery 14    │  1221.16 ms │                                    1228.69 ms │     no change │
│ QQuery 15    │  1237.67 ms │                                    1248.12 ms │     no change │
│ QQuery 16    │  2534.31 ms │                                    2583.68 ms │     no change │
│ QQuery 17    │  2495.38 ms │                                    2510.73 ms │     no change │
│ QQuery 18    │  5643.93 ms │                                    4857.99 ms │ +1.16x faster │
│ QQuery 19    │   125.79 ms │                                     121.88 ms │     no change │
│ QQuery 20    │  1903.89 ms │                                    1859.16 ms │     no change │
│ QQuery 21    │  2173.47 ms │                                    2173.50 ms │     no change │
│ QQuery 22    │  3708.83 ms │                                    3716.54 ms │     no change │
│ QQuery 23    │ 12566.32 ms │                                   12060.15 ms │     no change │
│ QQuery 24    │   206.30 ms │                                     222.46 ms │  1.08x slower │
│ QQuery 25    │   461.14 ms │                                     471.41 ms │     no change │
│ QQuery 26    │   218.29 ms │                                     230.93 ms │  1.06x slower │
│ QQuery 27    │  2768.38 ms │                                    2723.37 ms │     no change │
│ QQuery 28    │ 22270.94 ms │                                   21962.09 ms │     no change │
│ QQuery 29    │   966.81 ms │                                     975.49 ms │     no change │
│ QQuery 30    │  1334.09 ms │                                    1322.02 ms │     no change │
│ QQuery 31    │  1350.35 ms │                                    1322.18 ms │     no change │
│ QQuery 32    │  4955.09 ms │                                    4842.77 ms │     no change │
│ QQuery 33    │  6094.89 ms │                                    5932.90 ms │     no change │
│ QQuery 34    │  6007.78 ms │                                    6021.85 ms │     no change │
│ QQuery 35    │  1943.17 ms │                                    1942.33 ms │     no change │
│ QQuery 36    │    66.79 ms │                                      66.06 ms │     no change │
│ QQuery 37    │    45.81 ms │                                      45.88 ms │     no change │
│ QQuery 38    │    69.58 ms │                                      68.42 ms │     no change │
│ QQuery 39    │   104.40 ms │                                     106.35 ms │     no change │
│ QQuery 40    │    27.26 ms │                                      28.32 ms │     no change │
│ QQuery 41    │    24.58 ms │                                      23.48 ms │     no change │
│ QQuery 42    │    20.35 ms │                                      20.87 ms │     no change │
└──────────────┴─────────────┴───────────────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                                            ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                                            │ 92754.01ms │
│ Total Time (improve-performance-by-avoiding-double-search)   │ 91088.09ms │
│ Average Time (HEAD)                                          │  2157.07ms │
│ Average Time (improve-performance-by-avoiding-double-search) │  2118.33ms │
│ Queries Faster                                               │          1 │
│ Queries Slower                                               │          2 │
│ Queries with No Change                                       │         40 │
│ Queries with Failure                                         │          0 │
└──────────────────────────────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query        ┃      HEAD ┃ improve-performance-by-avoiding-double-search ┃    Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 1     │ 112.33 ms │                                     115.28 ms │ no change │
│ QQuery 2     │  29.48 ms │                                      30.27 ms │ no change │
│ QQuery 3     │  38.82 ms │                                      39.16 ms │ no change │
│ QQuery 4     │  29.09 ms │                                      29.68 ms │ no change │
│ QQuery 5     │  88.81 ms │                                      88.79 ms │ no change │
│ QQuery 6     │  20.07 ms │                                      19.71 ms │ no change │
│ QQuery 7     │ 240.55 ms │                                     236.41 ms │ no change │
│ QQuery 8     │  37.93 ms │                                      37.20 ms │ no change │
│ QQuery 9     │ 107.18 ms │                                     107.89 ms │ no change │
│ QQuery 10    │  62.08 ms │                                      62.80 ms │ no change │
│ QQuery 11    │  17.68 ms │                                      18.52 ms │ no change │
│ QQuery 12    │  51.73 ms │                                      51.69 ms │ no change │
│ QQuery 13    │  47.61 ms │                                      49.91 ms │ no change │
│ QQuery 14    │  13.87 ms │                                      14.24 ms │ no change │
│ QQuery 15    │  24.82 ms │                                      25.35 ms │ no change │
│ QQuery 16    │  24.11 ms │                                      24.72 ms │ no change │
│ QQuery 17    │ 155.47 ms │                                     154.34 ms │ no change │
│ QQuery 18    │ 279.82 ms │                                     280.20 ms │ no change │
│ QQuery 19    │  39.14 ms │                                      38.37 ms │ no change │
│ QQuery 20    │  49.69 ms │                                      48.40 ms │ no change │
│ QQuery 21    │ 323.24 ms │                                     309.94 ms │ no change │
│ QQuery 22    │  17.66 ms │                                      17.32 ms │ no change │
└──────────────┴───────────┴───────────────────────────────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary                                            ┃           ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD)                                            │ 1811.18ms │
│ Total Time (improve-performance-by-avoiding-double-search)   │ 1800.19ms │
│ Average Time (HEAD)                                          │   82.33ms │
│ Average Time (improve-performance-by-avoiding-double-search) │   81.83ms │
│ Queries Faster                                               │         0 │
│ Queries Slower                                               │         0 │
│ Queries with No Change                                       │        22 │
│ Queries with Failure                                         │         0 │
└──────────────────────────────────────────────────────────────┴───────────┘

perf: skip double lookup in multi group by hash map

936bd9a

github-actions bot added common Related to common crate physical-plan Changes to the physical-plan crate labels Dec 20, 2025

rluvaton added the performance Make DataFusion faster label Dec 20, 2025

rluvaton marked this pull request as draft December 20, 2025 22:14

perf: skip double lookup in multi group by hash map #19430

Are you sure you want to change the base?

perf: skip double lookup in multi group by hash map #19430

Conversation

rluvaton commented Dec 20, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

rluvaton commented Dec 20, 2025

Uh oh!

alamb-ghbot commented Dec 20, 2025

Uh oh!

alamb-ghbot commented Dec 20, 2025

Uh oh!

Dandandan commented Dec 21, 2025

Uh oh!

Dandandan commented Dec 21, 2025

Uh oh!

alamb commented Dec 21, 2025

Uh oh!

alamb commented Dec 21, 2025

Uh oh!

alamb commented Dec 21, 2025

Uh oh!

alamb-ghbot commented Dec 21, 2025

Uh oh!

alamb-ghbot commented Dec 21, 2025

Uh oh!

alamb-ghbot commented Dec 21, 2025

Uh oh!

alamb-ghbot commented Dec 21, 2025

Uh oh!

alamb-ghbot commented Dec 21, 2025

Uh oh!

alamb-ghbot commented Dec 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants