Fix Duplicated filters within (filter(TableScan)) plan for unparser#13422
Merged
jayzhan211 merged 5 commits intoapache:mainfrom Nov 27, 2024
Merged
Fix Duplicated filters within (filter(TableScan)) plan for unparser#13422jayzhan211 merged 5 commits intoapache:mainfrom
jayzhan211 merged 5 commits intoapache:mainfrom
Conversation
* Eliminate duplicated filter within (filter(TableScan)) plan * Updates * fix * add test * fix
jayzhan211
reviewed
Nov 14, 2024
alamb
reviewed
Nov 15, 2024
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thank you @Sevenannn -- this is a great idea. Thank you @jayzhan211 for the review
Contributor
|
Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look |
Contributor
|
Thanks @Sevenannn @alamb |
Contributor
Author
|
Thanks @jayzhan211 @alamb |
Contributor
Thank you for all the bug fixes @Sevenannn -- it turns out that @wiedld just found you had fixed a bug we ran into in InfluxDB as well (#12979) 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
when rewriting plans that has aggregates with lhs / rhs with filter and scan containing same filter.
For query
The logical plan is
The rewritten query will be:
SELECT customer.c_custkey, count(orders.o_orderkey) FROM customer LEFT JOIN orders ON ((customer.c_custkey = orders.o_custkey) AND (orders.o_comment NOT LIKE '%special%requests%' AND orders.o_comment NOT LIKE '%special%requests%')) GROUP BY customer.c_custkeyUnder the current approach, the filter
orders.o_comment NOT LIKE Utf8("%special%requests%")will occur twice in final query, although this has no effect on query result correctness, it brings performance overhead by including duplicated conditions.What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No