Support COPY TO Externally Defined File Formats, add FileType trait#11060
Merged
alamb merged 23 commits intoapache:mainfrom Jun 28, 2024
Merged
Support COPY TO Externally Defined File Formats, add FileType trait#11060alamb merged 23 commits intoapache:mainfrom
alamb merged 23 commits intoapache:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8345
Revives #8667
Rationale for this change
Previously,
COPY TOqueries could only be planned/executed for a preset enum ofFileTypes.CREATE EXTERNAL TABLEsupports arbitrary file formats via theFileFormatandTableProvidertraits. This PR removes theFileTypeenum in favor of aFileTypetrait and updatesCOPY TOplans to work with any externally implementeddyn FileFormat.This PR also enables future work to remove csv, parquet, json, ect... formats into dedicated crates (datafusion-csv, ...).
What changes are included in this PR?
FileTypeenum and replaces with a traitFileFormatthat implementsFileTypeto enable conversions between the twoLogicalExtensionCodecto allow serde ofdyn FileTypeAre these changes tested?
Existing tests verify behavior for currently supported formats remains the same.
Are there any user-facing changes?
Yes, there are API changes relevant for developers using DataFusion.