Minor: Improve ListingTable documentation#10854
Merged
alamb merged 2 commits intoapache:mainfrom Jun 11, 2024
Merged
Conversation
comphead
reviewed
Jun 11, 2024
comphead
approved these changes
Jun 11, 2024
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
Contributor
Author
|
Thanks again for the review @comphead |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Minor: Improve ListingTable documentation * Update datafusion/core/src/datasource/listing/table.rs Co-authored-by: Oleks V <comphead@users.noreply.github.com> --------- Co-authored-by: Oleks V <comphead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #10693
Rationale for this change
@houqp added a great feaure in #10693 that I wanted to make sure was documented
Also, as I am working on #10481 I found I had to explain what LIstingTable was so already had a good example
What changes are included in this PR?
Improve docstrings and example of
ListingTableAre these changes tested?
Doc CI check
Are there any user-facing changes?
Documentation, no functional changes