snowflake: Fix handling of /~% in the stage name#1009
Merged
alamb merged 2 commits intoapache:mainfrom Oct 26, 2023
Merged
Conversation
lustefaniak
changed the title
/~% in the stage name
Pull Request Test Coverage Report for Build 6652040155
💛 - Coveralls |
alamb
reviewed
Oct 24, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @lustefaniak -- I have a question about why the tests were changed
Perhaps @pawel-big-lebowski can help review this as the author of #841
Contributor
|
Just wanted to say thanks to @lustefaniak - I also noticed this issue and wanted to tackle it. |
lustefaniak
force-pushed
the
snowflake-division
branch
from
616ab19 to
02fe126
Compare
pawel-big-lebowski
approved these changes
Oct 26, 2023
Contributor
pawel-big-lebowski
left a comment
pawel-big-lebowski
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
Great job.
alamb
approved these changes
Oct 26, 2023
Contributor
There was a problem hiding this comment.
Thank you @lustefaniak for both this PR as well as #1025 -- they look great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1008
Changed as discussed in the code review. Tokenizer accepts
/,%,~normally, and then when parsing stage name, that is accepted as part of identifier.