chore: fix docker-publish attempt 1

[andygrove]

Which issue does this PR close?

N/A

Rationale for this change

What changes are included in this PR?

How are these changes tested?

[andygrove]

@edmondop fyi

[andygrove]

we were missing the jobs part before

[edmondop]

I have run the pipeline locally using act like so:

act -e event.json push

with the following event.json

{
  "ref": "refs/tags/test-docker-publish-foo"
}

and it fail with the following error:

R Build/ubuntu-latest/java 11-spark-3.4-scala-2.13/java-11                                 ] 🚀  Start image=amd64/rust
[PR Build/ubuntu-latest/java 17-spark-3.4-scala-2.13/java-12                                 ] 🚀  Start image=amd64/rust
[PR Build/ubuntu-latest/java 11-spark-3.4-scala-2.13/java-11                                 ]   🐳  docker pull image=amd64/rust platform= username= forcePull=true
[PR Build/ubuntu-latest/java 17-spark-3.4-scala-2.13/java-12                                 ]   🐳  docker pull image=amd64/rust platform= username= forcePull=true
[PR Build/ubuntu-latest/java 8-spark-3.4-scala-2.12/java-7                                   ]   🐳  docker create image=amd64/rust platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[PR Build/ubuntu-latest/java 11-spark-3.4-scala-2.13/java-11                                 ]   🐳  docker create image=amd64/rust platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[PR Build/ubuntu-latest/java 17-spark-3.4-scala-2.13/java-12                                 ]   🐳  docker create image=amd64/rust platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[Run Miri Safety Checks/Miri                                                                 ]   🐳  docker create image=catthehacker/ubuntu:full-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[Deploy DataFusion Comet site/Build docs                                                     ]   🐳  docker create image=catthehacker/ubuntu:full-latest platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
[Publish Docker images/Docker                                                                ]   🐳  docker create image=catthehacker/ubuntu:full-22.04 platform= entrypoint=["tail" "-f" "/dev/null"] cmd=[] network="host"
Error: failed to create container: 'Error response from daemon: No such image: amd64/rust:latest'

it could be a problem with act or a legitimate missing variable

[edmondop]

Nevermind, it looks like I have some proxy settings that do not allow me to pull the image, but the pipeline is valid

[edmondop]

Running actionlint

still shows errors:

 actionlint
.github/workflows/docker-publish.yml:40:15: missing input "distribution" which is required by action "actions/setup-java@v3". all required inputs are "distribution" [action]
   |
40 |         uses: actions/setup-java@v3
   |               ^~~~~~~~~~~~~~~~~~~~~
.github/workflows/pr_build.yml:152:15: name is required in action metadata "/Users/lbs795/Development/other/comet/datafusion-comet/.github/actions/rust-test/action.yaml" [action]
    |
152 |         uses: ./.github/actions/rust-test
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/pr_build.yml:152:15: description is required in metadata of "" action at "/Users/lbs795/Development/other/comet/datafusion-comet/.github/actions/rust-test/action.yaml" [action]
    |
152 |         uses: ./.github/actions/rust-test
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/pr_build.yml:225:27: value "11" in "exclude" does not match in matrix "java_version" combinations. possible values are "17" [matrix]
    |
225 |           - java_version: 11
    |                           ^~

@andygrove do you want to download actionlint and run it locally https://github.com/rhysd/actionlint/blob/main/docs/install.md?

[andygrove]

Running actionlint

still shows errors:

 actionlint
.github/workflows/docker-publish.yml:40:15: missing input "distribution" which is required by action "actions/setup-java@v3". all required inputs are "distribution" [action]
   |
40 |         uses: actions/setup-java@v3
   |               ^~~~~~~~~~~~~~~~~~~~~
.github/workflows/pr_build.yml:152:15: name is required in action metadata "/Users/lbs795/Development/other/comet/datafusion-comet/.github/actions/rust-test/action.yaml" [action]
    |
152 |         uses: ./.github/actions/rust-test
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/pr_build.yml:152:15: description is required in metadata of "" action at "/Users/lbs795/Development/other/comet/datafusion-comet/.github/actions/rust-test/action.yaml" [action]
    |
152 |         uses: ./.github/actions/rust-test
    |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~
.github/workflows/pr_build.yml:225:27: value "11" in "exclude" does not match in matrix "java_version" combinations. possible values are "17" [matrix]
    |
225 |           - java_version: 11
    |                           ^~

@andygrove do you want to download actionlint and run it locally https://github.com/rhysd/actionlint/blob/main/docs/install.md?

Thank you. I did not know about this. I will try this out tomorrow