CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type #868

anshul1886 · 2015-09-22T06:22:08Z

It fixes the bug https://issues.apache.org/jira/browse/CLOUDSTACK-8894.

Steps:
1.Install and configure XenServer 6.5 with vGPU enabled . Enabled dynamic scaliing
2. Deploy VM using K160Q type windows 7 template with PV tools installaed and dynamic scaling enabled
3. Tried dynamic scaling with offering which has K180Q defined.
Observation:

Currently vGPU resource dynamic scaling is not supported. But CloudStack returns success and updating the VM details with new offering details including new vGPU type.
But from Xenserver , There is no change with vGPU type and it remains with old vGPU type. This is not correct
Expected Result:
Dynamic scaling should be restricted when source/destination offering has vGPU type on a vGPU enabled VM

asfbot · 2015-09-22T06:47:36Z

cloudstack-pull-rats #692 SUCCESS
This pull request looks good

asfbot · 2015-09-22T07:53:35Z

cloudstack-pull-analysis #642 SUCCESS
This pull request looks good

sebgoa · 2015-09-30T08:15:48Z

@anshul1886 Can you add a bit of a description here.
Is that fixing a bug, is that a new feature ? Can you add Travis tests to check this ?
many thanks

anshul1886 · 2015-09-30T08:41:54Z

@Runseb Updated the bug description. I am looking into travis tests. This test will require vGPU enabled hosts with different type of GPU cards.

anshul1886 · 2015-09-30T09:46:16Z

@Runseb It seems like simulator does't have support for vGPU. If I find some time then I will try to add support for it.

pedro-martins · 2016-02-05T14:37:17Z

server/src/com/cloud/vm/UserVmManagerImpl.java

+            }
+        }
+
        // Check resource limits


Hi @anshul1886,
Could you extract the codes between lines 1541 - 1549 to a method with an auto described name, do some test cases to this new method and create a Javadoc explaining what the method do, what params it receive, the exceptions it throws and what can cause the exception?
Ty.

@pedro-martins I would prefer it this way for readability.

yadvr · 2016-05-02T10:32:27Z

@anshul1886 please rebase against latest master and push -f, update on status of your PR

bvbharatk · 2016-06-01T23:49:43Z

ACS CI BVT Run

Sumarry:
Build Number 108
Hypervisor xenserver
NetworkType Advanced
Passed=72
Failed=1
Skipped=3

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

test_vm_life_cycle.py
- test_10_attachAndDetach_iso Failing since 3 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

…vice offering has different vGPU type

anshul1886 · 2017-02-28T12:29:25Z

@rhtyd, Rebased against latest master.

cloudmonger · 2017-03-01T12:21:18Z

ACS CI BVT Run

Sumarry:
Build Number 407
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=7

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py

nitin-maharana · 2017-04-28T06:18:25Z

Code LGTM.

Just curious to know, Do we support upgrading/downgrading the stopped VM with different vgpuTypes on XS.

nitin-maharana · 2017-04-28T06:13:54Z

server/src/com/cloud/vm/UserVmManagerImpl.java

                    + ",memory=," + currentMemory + ")");
        }

+        _offeringDao.loadDetails(currentServiceOffering);


For a bit of improvement, before loading, we can check if the value is already loaded then we can skip this, else load it. Something like this.

if(currentServiceOffering.getDetails() == null) {
_offeringDao.loadDetails(currentServiceOffering);
}

Same for newServiceOffering.

@nitin-maharana This check will be redundant as there is no place where details are getting set in variable's lifetime.

anshul1886 · 2017-05-17T06:09:55Z

@nitin-maharana Yes we support upgrading/downgrading the stopped VM. But both service offerings should have same vGPU type as that is currently not supported.

yadvr · 2017-05-17T07:49:45Z

There were outstanding comments on this PR which were not addressed and the PR was merged :(

Co-authored-by: Rakesh Venkatesh <[email protected]> Signed-off-by: Rohit Yadav <[email protected]>

pedro-martins reviewed Feb 5, 2016
View reviewed changes

CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new ser…

f9f0e50

…vice offering has different vGPU type

anshul1886 force-pushed the CLOUDSTACK-8894 branch from 8c00e44 to f9f0e50 Compare February 28, 2017 12:28

anshul1886 closed this Mar 7, 2017

anshul1886 reopened this Mar 7, 2017

nitin-maharana reviewed Apr 28, 2017

View reviewed changes

karuturi added the status:waiting-for-author label May 10, 2017

kiwiflyer added the type:bug label May 10, 2017

karuturi removed the status:waiting-for-author label May 17, 2017

karuturi added this to the 4.10.0.0 milestone May 17, 2017

karuturi merged commit e77a2f8 into apache:master May 17, 2017

yadvr pushed a commit that referenced this pull request Jan 20, 2021

Display IP address while deleting it (#868)

89445d2

Co-authored-by: Rakesh Venkatesh <[email protected]> Signed-off-by: Rohit Yadav <[email protected]>

CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type #868

CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type #868

Uh oh!

Conversation

anshul1886 commented Sep 22, 2015

Uh oh!

asfbot commented Sep 22, 2015

Uh oh!

asfbot commented Sep 22, 2015

Uh oh!

sebgoa commented Sep 30, 2015

Uh oh!

anshul1886 commented Sep 30, 2015

Uh oh!

anshul1886 commented Sep 30, 2015

Uh oh!

pedro-martins Feb 5, 2016

Choose a reason for hiding this comment

Uh oh!

anshul1886 Mar 9, 2017

Choose a reason for hiding this comment

Uh oh!

yadvr commented May 2, 2016

Uh oh!

bvbharatk commented Jun 1, 2016

ACS CI BVT Run

Uh oh!

anshul1886 commented Feb 28, 2017

Uh oh!

cloudmonger commented Mar 1, 2017

ACS CI BVT Run

Uh oh!

nitin-maharana commented Apr 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nitin-maharana Apr 28, 2017

Choose a reason for hiding this comment

Uh oh!

anshul1886 May 17, 2017

Choose a reason for hiding this comment

Uh oh!

anshul1886 commented May 17, 2017

Uh oh!

yadvr commented May 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

nitin-maharana commented Apr 28, 2017 •

edited

Loading