Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (09636cf) 15.86% compared to head (79b1490) 15.86%.
Report is 3 commits behind head on nsx-integration.

Files Patch % Lines
...java/org/apache/cloudstack/service/NsxElement.java 42.85% 15 Missing and 1 partial ⚠️
...a/com/cloud/network/vpc/NetworkACLManagerImpl.java 0.00% 8 Missing ⚠️
...a/com/cloud/network/vpc/NetworkACLServiceImpl.java 46.66% 7 Missing and 1 partial ⚠️
...com/cloud/network/element/BigSwitchBcfElement.java 0.00% 1 Missing ⚠️
...rk/contrail/management/ContrailVpcElementImpl.java 0.00% 1 Missing ⚠️
...cloud/network/element/VpcVirtualRouterElement.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             nsx-integration    #8618      +/-   ##
=====================================================
- Coverage              15.86%   15.86%   -0.01%     
+ Complexity             16011    16010       -1     
=====================================================
  Files                   5155     5155              
  Lines                 363466   363502      +36     
  Branches               53192    53200       +8     
=====================================================
- Hits                   57658    57655       -3     
- Misses                299000   299038      +38     
- Partials                6808     6809       +1     
Flag Coverage Δ
uitests 4.36% <ø> (ø)
unit-tests 16.85% <35.18%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Feb 7, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@rohityadavcloud rohityadavcloud added this to the 20.0.0 milestone Feb 16, 2024
@Pearl1594
Copy link
Contributor Author

Already present in #7919

@Pearl1594 Pearl1594 closed this Jun 5, 2024
@DaanHoogland DaanHoogland removed this from the 4.20.0.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants