Skip to content

cks,ui: allow changing stopped cluster offering, improvements #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yadvr merged 4 commits into from
May 29, 2023
Merged

cks,ui: allow changing stopped cluster offering, improvements #7475

yadvr merged 4 commits into from
May 29, 2023

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Apr 26, 2023 •
edited
Loading

Description

Fixes #7454

  • Allows changing compute offering for a stopped cluster
  • Allows compute offering change when the cluster has autoscaling enabled

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Using cmk:

Service offerings:

(localcloud) 🐱 > list serviceofferings id=5b9471db-0f98-4ad4-8e27-d31935c1d5fe 
{
  "count": 1,
  "serviceoffering": [
    {
      "cacheMode": "none",
      "cpunumber": 2,
      "cpuspeed": 1000,
      "created": "2023-05-22T08:22:32+0000",
      "defaultuse": false,
      "diskofferingstrictness": false,
      "displaytext": "CKS Instance",
      "dynamicscalingenabled": true,
      "encryptroot": false,
      "hasannotations": false,
      "id": "5b9471db-0f98-4ad4-8e27-d31935c1d5fe",
      "iscustomized": false,
      "issystem": false,
      "isvolatile": false,
      "limitcpuuse": false,
      "memory": 2048,
      "name": "CKS Instance",
      "offerha": false,
      "provisioningtype": "thin",
      "rootdisksize": 0,
      "storagetype": "shared"
    }
  ]
}
(localcloud) 🐱 > list serviceofferings id=54a44f69-2803-4a84-aeca-df7f81aa9c1b 
{
  "count": 1,
  "serviceoffering": [
    {
      "cacheMode": "none",
      "cpunumber": 2,
      "cpuspeed": 1000,
      "created": "2023-05-23T11:58:51+0000",
      "defaultuse": false,
      "diskofferingstrictness": false,
      "displaytext": "Upgrade CKS Instance",
      "dynamicscalingenabled": true,
      "encryptroot": false,
      "hasannotations": false,
      "id": "54a44f69-2803-4a84-aeca-df7f81aa9c1b",
      "iscustomized": false,
      "issystem": false,
      "isvolatile": false,
      "limitcpuuse": false,
      "memory": 2560,
      "name": "Upgrade CKS Instance",
      "offerha": false,
      "provisioningtype": "thin",
      "rootdisksize": 0,
      "storagetype": "shared"
    }
  ]
}

k8s cluster deployment and stopping:

(localcloud) 🐱 > create kubernetescluster zoneid=28693109-f77c-42ad-a3d7-e04c40800e1f name=t1 description=t1 kubernetesversionid=53bf05e1-1b7b-49f3-976b-7127a62ab8a0 serviceofferingid=5b9471db-0f98-4ad4-8e27-d31935c1d5fe size=1
{
  "kubernetescluster": {
    "account": "admin",
    "associatednetworkname": "t1-network",
    "autoscalingenabled": false,
    "controlnodes": 1,
    "cpunumber": "4",
    "created": "2023-05-23T11:57:56+0000",
    "description": "t1",
    "domain": "ROOT",
    "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
    "endpoint": "https://10.0.54.163:6443/",
    "hasannotations": false,
    "id": "99c71dba-285c-48a7-942a-8e712e32e99d",
    "ipaddress": "10.0.54.163",
    "ipaddressid": "d973691c-4d20-4a29-871e-dbee002f8ba4",
    "kubernetesversionid": "53bf05e1-1b7b-49f3-976b-7127a62ab8a0",
    "kubernetesversionname": "v1.26.0",
    "masternodes": 1,
    "memory": "4096",
    "name": "t1",
    "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
    "serviceofferingid": "5b9471db-0f98-4ad4-8e27-d31935c1d5fe",
    "serviceofferingname": "CKS Instance",
    "size": 1,
    "state": "Running",
    "templateid": "11db18e7-43b7-4e3c-991c-a3b5c2f61968",
    "virtualmachines": [
      {
        "account": "admin",
        "affinitygroup": [],
        "created": "2023-05-23T11:58:31+0000",
        "details": {
          "controlNodeLoginUser": "cloud",
          "cpuOvercommitRatio": "2.0",
          "memoryOvercommitRatio": "1.0",
          "rootdisksize": "8"
        },
        "displayname": "t1-control-1884879a45c",
        "displayvm": true,
        "domain": "ROOT",
        "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
        "guestosid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "haenable": false,
        "hasannotations": false,
        "hostcontrolstate": "Enabled",
        "hostid": "cb8a8132-ef62-46df-b5b0-8a4cbeb41ca9",
        "hostname": "pr7479-t6536-kvm-centos7-kvm2",
        "hypervisor": "KVM",
        "id": "5f3da9b7-a7d7-4d2c-946c-719923506a39",
        "instancename": "i-2-65-VM",
        "isdynamicallyscalable": false,
        "lastupdated": "2023-05-23T11:58:43+0000",
        "name": "t1-control-1884879a45c",
        "nic": [
          {
            "broadcasturi": "vlan://1629",
            "deviceid": "0",
            "extradhcpoption": [],
            "gateway": "10.1.1.1",
            "id": "27252d7f-773a-4a67-97d3-81487ab41c0b",
            "ipaddress": "10.1.1.177",
            "isdefault": true,
            "isolationuri": "vlan://1629",
            "macaddress": "02:00:4a:bc:00:02",
            "netmask": "255.255.255.0",
            "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
            "networkname": "t1-network",
            "secondaryip": [],
            "traffictype": "Guest",
            "type": "Isolated"
          }
        ],
        "osdisplayname": "Debian GNU/Linux 5.0 (64-bit)",
        "ostypeid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "pooltype": "NetworkFilesystem",
        "receivedbytes": 0,
        "securitygroup": [],
        "sentbytes": 0,
        "state": "Running",
        "tags": [],
        "userid": "21d66d69-f85b-11ed-9f8f-1e009f00014a",
        "username": "admin",
        "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
        "zonename": "pr7479-t6536-kvm-centos7"
      },
      {
        "account": "admin",
        "affinitygroup": [],
        "created": "2023-05-23T11:58:44+0000",
        "details": {
          "controlNodeLoginUser": "cloud",
          "cpuOvercommitRatio": "2.0",
          "memoryOvercommitRatio": "1.0",
          "rootdisksize": "8"
        },
        "displayname": "t1-node-1884879d541",
        "displayvm": true,
        "domain": "ROOT",
        "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
        "guestosid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "haenable": false,
        "hasannotations": false,
        "hostcontrolstate": "Enabled",
        "hostid": "cb8a8132-ef62-46df-b5b0-8a4cbeb41ca9",
        "hostname": "pr7479-t6536-kvm-centos7-kvm2",
        "hypervisor": "KVM",
        "id": "c267ae48-b24b-45e4-a03c-d4a8d010e214",
        "instancename": "i-2-66-VM",
        "isdynamicallyscalable": false,
        "lastupdated": "2023-05-23T11:58:58+0000",
        "name": "t1-node-1884879d541",
        "nic": [
          {
            "broadcasturi": "vlan://1629",
            "deviceid": "0",
            "extradhcpoption": [],
            "gateway": "10.1.1.1",
            "id": "c8c43943-fb83-45ce-bdca-1cee12187296",
            "ipaddress": "10.1.1.2",
            "isdefault": true,
            "isolationuri": "vlan://1629",
            "macaddress": "02:00:30:c7:00:03",
            "netmask": "255.255.255.0",
            "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
            "networkname": "t1-network",
            "secondaryip": [],
            "traffictype": "Guest",
            "type": "Isolated"
          }
        ],
        "osdisplayname": "Debian GNU/Linux 5.0 (64-bit)",
        "ostypeid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "pooltype": "NetworkFilesystem",
        "receivedbytes": 0,
        "securitygroup": [],
        "sentbytes": 0,
        "state": "Running",
        "tags": [],
        "userid": "21d66d69-f85b-11ed-9f8f-1e009f00014a",
        "username": "admin",
        "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
        "zonename": "pr7479-t6536-kvm-centos7"
      }
    ],
    "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
    "zonename": "pr7479-t6536-kvm-centos7"
  }
}
(localcloud) 🐱 > stop kubernetescluster id=99c71dba-285c-48a7-942a-8e712e32e99d
{
  "success": true
}

Scale cluster for offering and start:

(localcloud) 🐱 > scale kubernetescluster id=99c71dba-285c-48a7-942a-8e712e32e99d serviceofferingid=54a44f69-2803-4a84-aeca-df7f81aa9c1b 
{
  "kubernetescluster": {
    "account": "admin",
    "associatednetworkname": "t1-network",
    "autoscalingenabled": false,
    "controlnodes": 1,
    "cpunumber": "4",
    "created": "2023-05-23T11:57:56+0000",
    "description": "t1",
    "domain": "ROOT",
    "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
    "endpoint": "https://10.0.54.163:6443/",
    "hasannotations": false,
    "id": "99c71dba-285c-48a7-942a-8e712e32e99d",
    "ipaddress": "10.0.54.163",
    "ipaddressid": "d973691c-4d20-4a29-871e-dbee002f8ba4",
    "kubernetesversionid": "53bf05e1-1b7b-49f3-976b-7127a62ab8a0",
    "kubernetesversionname": "v1.26.0",
    "masternodes": 1,
    "memory": "5120",
    "name": "t1",
    "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
    "serviceofferingid": "54a44f69-2803-4a84-aeca-df7f81aa9c1b",
    "serviceofferingname": "Upgrade CKS Instance",
    "size": 1,
    "state": "Stopped",
    "templateid": "11db18e7-43b7-4e3c-991c-a3b5c2f61968",
    "virtualmachines": [
      {
        "account": "admin",
        "affinitygroup": [],
        "created": "2023-05-23T11:58:31+0000",
        "details": {
          "Message.ReservedCapacityFreed.Flag": "false",
          "controlNodeLoginUser": "cloud",
          "cpuOvercommitRatio": "2.0",
          "memoryOvercommitRatio": "1.0",
          "rootdisksize": "8"
        },
        "displayname": "t1-control-1884879a45c",
        "displayvm": true,
        "domain": "ROOT",
        "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
        "guestosid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "haenable": false,
        "hasannotations": false,
        "hypervisor": "KVM",
        "id": "5f3da9b7-a7d7-4d2c-946c-719923506a39",
        "instancename": "i-2-65-VM",
        "isdynamicallyscalable": false,
        "lastupdated": "2023-05-23T12:21:50+0000",
        "name": "t1-control-1884879a45c",
        "nic": [
          {
            "deviceid": "0",
            "extradhcpoption": [],
            "gateway": "10.1.1.1",
            "id": "27252d7f-773a-4a67-97d3-81487ab41c0b",
            "ipaddress": "10.1.1.177",
            "isdefault": true,
            "macaddress": "02:00:4a:bc:00:02",
            "netmask": "255.255.255.0",
            "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
            "networkname": "t1-network",
            "secondaryip": [],
            "traffictype": "Guest",
            "type": "Isolated"
          }
        ],
        "osdisplayname": "Debian GNU/Linux 5.0 (64-bit)",
        "ostypeid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "pooltype": "NetworkFilesystem",
        "receivedbytes": 0,
        "securitygroup": [],
        "sentbytes": 0,
        "state": "Stopped",
        "tags": [],
        "userid": "21d66d69-f85b-11ed-9f8f-1e009f00014a",
        "username": "admin",
        "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
        "zonename": "pr7479-t6536-kvm-centos7"
      },
      {
        "account": "admin",
        "affinitygroup": [],
        "created": "2023-05-23T11:58:44+0000",
        "details": {
          "Message.ReservedCapacityFreed.Flag": "false",
          "controlNodeLoginUser": "cloud",
          "cpuOvercommitRatio": "2.0",
          "memoryOvercommitRatio": "1.0",
          "rootdisksize": "8"
        },
        "displayname": "t1-node-1884879d541",
        "displayvm": true,
        "domain": "ROOT",
        "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
        "guestosid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "haenable": false,
        "hasannotations": false,
        "hypervisor": "KVM",
        "id": "c267ae48-b24b-45e4-a03c-d4a8d010e214",
        "instancename": "i-2-66-VM",
        "isdynamicallyscalable": false,
        "lastupdated": "2023-05-23T12:21:54+0000",
        "name": "t1-node-1884879d541",
        "nic": [
          {
            "deviceid": "0",
            "extradhcpoption": [],
            "gateway": "10.1.1.1",
            "id": "c8c43943-fb83-45ce-bdca-1cee12187296",
            "ipaddress": "10.1.1.2",
            "isdefault": true,
            "macaddress": "02:00:30:c7:00:03",
            "netmask": "255.255.255.0",
            "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
            "networkname": "t1-network",
            "secondaryip": [],
            "traffictype": "Guest",
            "type": "Isolated"
          }
        ],
        "osdisplayname": "Debian GNU/Linux 5.0 (64-bit)",
        "ostypeid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "pooltype": "NetworkFilesystem",
        "receivedbytes": 0,
        "securitygroup": [],
        "sentbytes": 0,
        "state": "Stopped",
        "tags": [],
        "userid": "21d66d69-f85b-11ed-9f8f-1e009f00014a",
        "username": "admin",
        "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
        "zonename": "pr7479-t6536-kvm-centos7"
      }
    ],
    "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
    "zonename": "pr7479-t6536-kvm-centos7"
  }
}
(localcloud) 🐱 > list virtualmachines id=5f3da9b7-a7d7-4d2c-946c-719923506a39 filter=id,name,serviceofferingid,serviceofferingname
{
  "count": 1,
  "virtualmachine": [
    {
      "id": "5f3da9b7-a7d7-4d2c-946c-719923506a39",
      "name": "t1-control-1884879a45c",
      "serviceofferingid": "54a44f69-2803-4a84-aeca-df7f81aa9c1b",
      "serviceofferingname": "Upgrade CKS Instance"
    }
  ]
}
(localcloud) 🐱 > start kubernetescluster id=99c71dba-285c-48a7-942a-8e712e32e99d 
{
  "kubernetescluster": {
    "account": "admin",
    "associatednetworkname": "t1-network",
    "autoscalingenabled": false,
    "controlnodes": 1,
    "cpunumber": "4",
    "created": "2023-05-23T11:57:56+0000",
    "description": "t1",
    "domain": "ROOT",
    "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
    "endpoint": "https://10.0.54.163:6443/",
    "hasannotations": false,
    "id": "99c71dba-285c-48a7-942a-8e712e32e99d",
    "ipaddress": "10.0.54.163",
    "ipaddressid": "d973691c-4d20-4a29-871e-dbee002f8ba4",
    "kubernetesversionid": "53bf05e1-1b7b-49f3-976b-7127a62ab8a0",
    "kubernetesversionname": "v1.26.0",
    "masternodes": 1,
    "memory": "5120",
    "name": "t1",
    "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
    "serviceofferingid": "54a44f69-2803-4a84-aeca-df7f81aa9c1b",
    "serviceofferingname": "Upgrade CKS Instance",
    "size": 1,
    "state": "Running",
    "templateid": "11db18e7-43b7-4e3c-991c-a3b5c2f61968",
    "virtualmachines": [
      {
        "account": "admin",
        "affinitygroup": [],
        "created": "2023-05-23T11:58:31+0000",
        "details": {
          "Message.ReservedCapacityFreed.Flag": "false",
          "controlNodeLoginUser": "cloud",
          "cpuOvercommitRatio": "2.0",
          "memoryOvercommitRatio": "1.0",
          "rootdisksize": "8"
        },
        "displayname": "t1-control-1884879a45c",
        "displayvm": true,
        "domain": "ROOT",
        "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
        "guestosid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "haenable": false,
        "hasannotations": false,
        "hostcontrolstate": "Enabled",
        "hostid": "cb8a8132-ef62-46df-b5b0-8a4cbeb41ca9",
        "hostname": "pr7479-t6536-kvm-centos7-kvm2",
        "hypervisor": "KVM",
        "id": "5f3da9b7-a7d7-4d2c-946c-719923506a39",
        "instancename": "i-2-65-VM",
        "isdynamicallyscalable": false,
        "lastupdated": "2023-05-23T12:23:36+0000",
        "name": "t1-control-1884879a45c",
        "nic": [
          {
            "broadcasturi": "vlan://1629",
            "deviceid": "0",
            "extradhcpoption": [],
            "gateway": "10.1.1.1",
            "id": "27252d7f-773a-4a67-97d3-81487ab41c0b",
            "ipaddress": "10.1.1.177",
            "isdefault": true,
            "isolationuri": "vlan://1629",
            "macaddress": "02:00:4a:bc:00:02",
            "netmask": "255.255.255.0",
            "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
            "networkname": "t1-network",
            "secondaryip": [],
            "traffictype": "Guest",
            "type": "Isolated"
          }
        ],
        "osdisplayname": "Debian GNU/Linux 5.0 (64-bit)",
        "ostypeid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "pooltype": "NetworkFilesystem",
        "receivedbytes": 0,
        "securitygroup": [],
        "sentbytes": 0,
        "state": "Running",
        "tags": [],
        "userid": "21d66d69-f85b-11ed-9f8f-1e009f00014a",
        "username": "admin",
        "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
        "zonename": "pr7479-t6536-kvm-centos7"
      },
      {
        "account": "admin",
        "affinitygroup": [],
        "created": "2023-05-23T11:58:44+0000",
        "details": {
          "Message.ReservedCapacityFreed.Flag": "false",
          "controlNodeLoginUser": "cloud",
          "cpuOvercommitRatio": "2.0",
          "memoryOvercommitRatio": "1.0",
          "rootdisksize": "8"
        },
        "displayname": "t1-node-1884879d541",
        "displayvm": true,
        "domain": "ROOT",
        "domainid": "06f469cb-f85b-11ed-9f8f-1e009f00014a",
        "guestosid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "haenable": false,
        "hasannotations": false,
        "hostcontrolstate": "Enabled",
        "hostid": "a7f5d4cc-f9fa-4177-b0a4-d1ac44a2ec95",
        "hostname": "pr7479-t6536-kvm-centos7-kvm1",
        "hypervisor": "KVM",
        "id": "c267ae48-b24b-45e4-a03c-d4a8d010e214",
        "instancename": "i-2-66-VM",
        "isdynamicallyscalable": false,
        "lastupdated": "2023-05-23T12:23:48+0000",
        "name": "t1-node-1884879d541",
        "nic": [
          {
            "broadcasturi": "vlan://1629",
            "deviceid": "0",
            "extradhcpoption": [],
            "gateway": "10.1.1.1",
            "id": "c8c43943-fb83-45ce-bdca-1cee12187296",
            "ipaddress": "10.1.1.2",
            "isdefault": true,
            "isolationuri": "vlan://1629",
            "macaddress": "02:00:30:c7:00:03",
            "netmask": "255.255.255.0",
            "networkid": "fa5c4f55-1897-4418-9f5b-3f654e86cf7e",
            "networkname": "t1-network",
            "secondaryip": [],
            "traffictype": "Guest",
            "type": "Isolated"
          }
        ],
        "osdisplayname": "Debian GNU/Linux 5.0 (64-bit)",
        "ostypeid": "06fce009-f85b-11ed-9f8f-1e009f00014a",
        "pooltype": "NetworkFilesystem",
        "receivedbytes": 0,
        "securitygroup": [],
        "sentbytes": 0,
        "state": "Running",
        "tags": [],
        "userid": "21d66d69-f85b-11ed-9f8f-1e009f00014a",
        "username": "admin",
        "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
        "zonename": "pr7479-t6536-kvm-centos7"
      }
    ],
    "zoneid": "28693109-f77c-42ad-a3d7-e04c40800e1f",
    "zonename": "pr7479-t6536-kvm-centos7"
  }
}

Verify cluster VMs are having new offering:

(localcloud) 🐱 > list virtualmachines ids=5f3da9b7-a7d7-4d2c-946c-719923506a39,c267ae48-b24b-45e4-a03c-d4a8d010e214 filter=id,name,serviceofferingid,serviceofferingname,state
{
  "count": 2,
  "virtualmachine": [
    {
      "id": "5f3da9b7-a7d7-4d2c-946c-719923506a39",
      "name": "t1-control-1884879a45c",
      "serviceofferingid": "54a44f69-2803-4a84-aeca-df7f81aa9c1b",
      "serviceofferingname": "Upgrade CKS Instance",
      "state": "Running"
    },
    {
      "id": "c267ae48-b24b-45e4-a03c-d4a8d010e214",
      "name": "t1-node-1884879d541",
      "serviceofferingid": "54a44f69-2803-4a84-aeca-df7f81aa9c1b",
      "serviceofferingname": "Upgrade CKS Instance",
      "state": "Running"
    }
  ]
}

@shwstppr
cks,ui: allow changing stopped cluster offering, improvements
d133af8 
Fixes apache#7454

- Allows changing compute offering for a stopped cluster
- Allows compute offering change when the cluster has autoscaling enabled

Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

shwstppr commented Apr 26, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 26, 2023

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 26, 2023

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5979

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@shwstppr
Copy link
Contributor Author

shwstppr commented Apr 26, 2023

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 26, 2023

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 27, 2023

Trillian test result (tid-6474)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46975 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7475-t6474-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_vms_metrics_admin Error 3607.73 test_metrics_api.py
test_list_vms_metrics_history Error 7.48 test_metrics_api.py
test_list_volumes_metrics_history Error 8.46 test_metrics_api.py

shwstppr added 2 commits May 12, 2023 18:25
@shwstppr
refactor, test
7d6d1de 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
fix
fe85254 
Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr
Copy link
Contributor Author

shwstppr commented May 18, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 18, 2023

@shwstppr a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@shwstppr
license
cb3879d 
Signed-off-by: Abhishek Kumar <[email protected]>
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #7475 (cb3879d) into 4.18 (e166f96) will increase coverage by 0.26%.
The diff coverage is 47.36%.

@@             Coverage Diff              @@
##               4.18    #7475      +/-   ##
============================================
+ Coverage     12.70%   12.96%   +0.26%     
- Complexity     8673     8959     +286     
============================================
  Files          2715     2716       +1     
  Lines        256071   256144      +73     
  Branches      39926    39947      +21     
============================================
+ Hits          32541    33219     +678     
+ Misses       219391   218765     -626     
- Partials       4139     4160      +21
Impacted Files Coverage Δ
...KubernetesClusterResourceModifierActionWorker.java 0.00% <ø> (ø)
...er/actionworkers/KubernetesClusterScaleWorker.java 0.00% <0.00%> (ø)
...bernetes/cluster/KubernetesClusterManagerImpl.java 2.38% <78.26%> (+2.38%) ⬆️

... and 105 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan
Copy link

blueorangutan commented May 18, 2023

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6035

@shwstppr
Copy link
Contributor Author

shwstppr commented May 18, 2023

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented May 18, 2023

@shwstppr a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented May 18, 2023

Trillian test result (tid-6517)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42840 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7475-t6517-kvm-centos7.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestVPCRedundancy>:setup Error 0.00 test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn Failure 540.63 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Error 1158.39 test_vpc_vpn.py
test_01_vpc_site2site_vpn Error 446.54 test_vpc_vpn.py

@shwstppr
Copy link
Contributor Author

shwstppr commented May 22, 2023

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 22, 2023

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 22, 2023

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6101

@shwstppr
Copy link
Contributor Author

shwstppr commented May 22, 2023

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented May 22, 2023

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented May 23, 2023

Trillian test result (tid-6544)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43684 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7475-t6544-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@shwstppr shwstppr marked this pull request as ready for review May 23, 2023 08:56
DaanHoogland
DaanHoogland approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache weizhouapache added this to the 4.18.1.0 milestone May 25, 2023
@shwstppr shwstppr linked an issue May 26, 2023 that may be closed by this pull request
Not able to change compute offering in a Kubernetes cluster when using KVM VMs #7454
Closed
vladimirpetrov
vladimirpetrov approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing.

@yadvr yadvr merged commit f636580 into apache:4.18 May 29, 2023
@yadvr yadvr deleted the fix-cks-cluster-offering-scaling branch May 29, 2023 10:28
@yadvr yadvr mentioned this pull request May 29, 2023
Closed
@shwstppr shwstppr mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:kubernetes component:UI

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

Not able to change compute offering in a Kubernetes cluster when using KVM VMs

6 participants

@shwstppr @blueorangutan @DaanHoogland @vladimirpetrov @yadvr @weizhouapache