-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[UI] Use CPU frequency of constrained offerings when importing VMs #7222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Use CPU frequency of constrained offerings when importing VMs #7222
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7222 +/- ##
=========================================
Coverage 12.67% 12.67%
Complexity 8639 8639
=========================================
Files 2716 2716
Lines 256112 256112
Branches 39926 39926
=========================================
Hits 32456 32456
Misses 219528 219528
Partials 4128 4128 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
stephankruggg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@stephankruggg did you test or just review? |
CLGTM* |
That's ok, I just want to make sure. |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@blueorangutan package |
|
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6129 |
RodrigoDLopez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested, everything works as expected. Lgtm








Description
Using the VMware hypervisor, when importing a VM from vCenter via UI, if a custom constrained offering is used, the CPU frequency is not passed to the backend, causing an error. This PR aims to fix this behavior.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
It was tested in a local lab: