Skip to content

Conversation

@SadiJr
Copy link
Contributor

@SadiJr SadiJr commented Feb 14, 2023

Description

Using the VMware hypervisor, when importing a VM from vCenter via UI, if a custom constrained offering is used, the CPU frequency is not passed to the backend, causing an error. This PR aims to fix this behavior.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

It was tested in a local lab:

  1. I created one new VM and one custom constrained offering;
  2. I tried importing this VM as root admin with the newly created custom constrained offering;
  3. Before, the VM was not imported with an error of CPU frequency;
  4. Now, the VM is correctly imported.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #7222 (0dcd66c) into main (597a803) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7222   +/-   ##
=========================================
  Coverage     12.67%   12.67%           
  Complexity     8639     8639           
=========================================
  Files          2716     2716           
  Lines        256112   256112           
  Branches      39926    39926           
=========================================
  Hits          32456    32456           
  Misses       219528   219528           
  Partials       4128     4128           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephankruggg stephankruggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland
Copy link
Contributor

@stephankruggg did you test or just review?

@stephankruggg
Copy link
Contributor

@stephankruggg did you test or just review?

CLGTM*
Not manually tested, sorry for the typo.

@DaanHoogland
Copy link
Contributor

@stephankruggg did you test or just review?

CLGTM* Not manually tested, sorry for the typo.

That's ok, I just want to make sure.

@weizhouapache weizhouapache added this to the 4.18.1.0 milestone May 12, 2023
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7222 (QA-JID-113)

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 6129

Copy link
Contributor

@RodrigoDLopez RodrigoDLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested, everything works as expected. Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants