vmware: do not create vm datastore when attach an existing volume on solidfire

[weizhouapache]

Description

This PR may fix #7148 , solidfire users are requested to test it.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5481

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[weizhouapache]

@blueorangutan test rocky8 vmware-70u3

[blueorangutan]

@weizhouapache a Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

Trillian Build Failed (tid-6085)

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6040

[DaanHoogland]

cLGTM

[shwstppr]

code LGTM

[shwstppr]

@blueorangutan test rocky8 vmware-67u3

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-6529)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 54843 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7160-t6529-vmware-67u3.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	Error	18.67	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	Error	3602.74	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	Error	1.32	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	Error	2.31	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	Error	2.30	test_vm_deployment_planner.py
test_09_expunge_vm	Failure	424.61	test_vm_life_cycle.py

[DaanHoogland]

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

[weizhouapache]

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@DaanHoogland
I am ok with merging this. but you know, I am the author :-)

[DaanHoogland]

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@DaanHoogland I am ok with merging this. but you know, I am the author :-)

yes, but you kept it in draft untill now, so I am checking with you anyway.

[weizhouapache]

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@DaanHoogland I am ok with merging this. but you know, I am the author :-)

yes, but you kept it in draft untill now, so I am checking with you anyway.

ah, moved it to "ready for review".
I will merge this if there is no objection until the end of Friday

[DaanHoogland]

@weizhouapache will we merge this? it is not harming anything as far as we can see, and only solidfire users can test it for us.

@DaanHoogland I am ok with merging this. but you know, I am the author :-)

yes, but you kept it in draft untill now, so I am checking with you anyway.

ah, moved it to "ready for review". I will merge this if there is no objection until the end of Friday

ok, let's merge as you suggested but keep the issue open as @rohityadavcloud suggested until a solidfire user confirmed.

[rohityadavcloud]

@weizhouapache I've tested this fix backported to a 4.17 env with Solidfire and VMware; it fixes the issue of previously failured where it would attempt to create datastore on an already created datastore for a solidfire iSCSI target. However, it doesn't address the issue #7148 completely.