Skip to content

ui: fix zone icon in vm deploy zone selection #6543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yadvr merged 2 commits into from
Jul 8, 2022
Merged

ui: fix zone icon in vm deploy zone selection #6543

yadvr merged 2 commits into from
Jul 8, 2022

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jul 8, 2022

Description

Fixes #6534

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2022-07-08 14-08-21

Before:

After:
Screenshot from 2022-07-08 14-13-12

How Has This Been Tested?

@shwstppr shwstppr requested a review from Pearl1594 July 8, 2022 08:46
@acs-robot
Copy link

acs-robot commented Jul 8, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 8, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 8, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6543 (SL-JID-1922)

Pearl1594
Pearl1594 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shwstppr
unnecessary conditions
3937efe 
Signed-off-by: Abhishek Kumar <[email protected]>
@acs-robot
Copy link

acs-robot commented Jul 8, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Jul 8, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 8, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6543 (SL-JID-1926)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yadvr yadvr added this to the 4.17.1.0 milestone Jul 8, 2022
@yadvr yadvr changed the base branch from main to 4.17 July 8, 2022 14:29
@yadvr yadvr merged commit 764ee30 into apache:4.17 Jul 8, 2022
@yadvr yadvr mentioned this pull request Jul 8, 2022
Closed
weizhouapache added a commit that referenced this pull request Sep 7, 2022
@weizhouapache
AS UI: apply patches for DeployVm.vue on CreateAutoScaleVmGroup.vue
71a1222 
ui: fix zone icon in vm deploy zone selection (#6543)
ui: remove incorrect API calls when initializing the deploy VM page (#6687)
ui: Fix netowrkid not passed in deployvm (#6711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@utchoang utchoang utchoang approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

CS 4.17 Zone icon does not render in Add Instance page (section 1)

7 participants

@shwstppr @acs-robot @blueorangutan @Pearl1594 @sureshanaparti @utchoang @yadvr