Skip to content

Conversation

@DaanHoogland
Copy link
Contributor

Description

This PR disables the SuperLinter which always claims there are failures even if there is nothing to report.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohityadavcloud
Copy link
Member

With #6531 this may not be needed if the lint is fixed, if we think it's not necessary (as travis does some lint checks too?) let's remove this indeed.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland
Copy link
Contributor Author

@jbampton can you comment please? i lost track of our pre-commit track record.

@jbampton
Copy link
Member

jbampton commented Jul 7, 2022

The flake8 lint fix was here #6529 which added a single line at the end of a Python file.

So the Super Linter was taking over 10 minutes to run. So in #6531 we changed the linter to just check the files in each pull request and it now takes about 2 minutes to run.

Seems having a blank line at the end of a file is best practice.

Flake8 is now linting for 3 rules all whitespace related shown here

select = W291,W292,W293

Python has PEP 8 – Style Guide for Python Code and whilst you don't have to follow it, it does talk about some best practices.

https://peps.python.org/pep-0008/

So this work with the Super-Linter is all about code standards.

I think using pre-commit is just the next extension to getting all the linters/checks running on your local machine.

I would be happy to write up some docs if needed on all this.

@DaanHoogland
Copy link
Contributor Author

@rohityadavcloud if @jbampton is right I'd rather disable the checks in travis as they take longer and travis has enough to do anyway.
And I think we can close this consequently.

@rohityadavcloud
Copy link
Member

Travis lint checks are somehow quicker and only done via job #1 which only does build related checks (doesn't run more than one simple smoketests). Job #1 is usually fastest among rest of the jobs.

@rohityadavcloud rohityadavcloud added this to the 4.18.0.0 milestone Oct 8, 2022
@DaanHoogland DaanHoogland removed this from the 4.18.0.0 milestone Oct 26, 2022
@DaanHoogland DaanHoogland deleted the disableLinter branch August 16, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants