ui: fix filtering readonly details while VM update

[shwstppr]

Description

Fixes #5724

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Before fix (filtering of readonly details not working properly and updateVirtualMachine is called with rootDiskController setting)
Steps to reproduce:

• On a VMware env, as a regular user deploy a VM, stop it after deployment. Template shouldn't have nicAdapter specified
• Try to update VM with nicAdapter from UI by adding the new setting.
• Observe updateVirtualMachine API is called with rootDiskController in the details
  

After fix:

How Has This Been Tested?

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5887 (SL-JID-1055)

[sureshanaparti]

Verified fix. LGTM

[DaanHoogland]

code looks good, but can you give a short brief as to how and why this solves the issue? It looks to be functionally the same, the filter only starting on the other end of the list.

[shwstppr]

@DaanHoogland I've changed loop to iterate from end of the list. As it was removing elements from the list in the loop, original code was having issues while removing multiple items.

[utchoang]

LGTM!

[GutoVeronezi]

LGTM

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[sureshanaparti]

@shwstppr when i add a read-only detail, it is ignored. please check.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5887 (SL-JID-1074)

[Pearl1594]

LGTM

[sureshanaparti]

Verified latest changes. LGTM.