server: cannot deploy/start vm if service offering has multiple tags

[weizhouapache]

Description

This PR fixes an issue in #4399

Steps to reproduce the issue
(1) create service offering with multiple host tags (2 or more)
(2) create a vm with the service offering

expected result
vm is started or
get error message "No suitable host found for follow compute offering tags: tag1,tag2"

actual result:
Got exception

com.cloud.utils.exception.CloudRuntimeException: DB Exception on: select distinct cluster_id from host join host_tags on host.id = host_tags.host_id and host_tags.tag = ?

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1426

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[nvazquez]

LGTM - Manually verified

[nvazquez]

Ping for review @sureshanaparti @davidjumani @rhtyd

[blueorangutan]

Trillian test result (tid-2229)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31149 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5521-t2229-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[rohityadavcloud]

Should %s be replaced with ?

[sureshanaparti]

@rhtyd It seems, all the tags are part of the sub-query stmt "LIST_HOST_IDS_BY_COMPUTETAGS" and the returned hosts from that sub-query were considered from further filtering.

[weizhouapache]

Should %s be replaced with ?

@rhtyd
see suresh's comment above.

cloudstack/engine/schema/src/main/java/com/cloud/host/dao/HostDaoImpl.java

Lines 1208 to 1213 in fccd02b

	String sql = this.LIST_CLUSTERID_FOR_HOST_TAG;
	PreparedStatement pstmt = null;
	List<Long> result = new ArrayList();
	List<String> tags = Arrays.asList(computeOfferingTags.split(this.SEPARATOR));
	String subselect = getHostIdsByComputeTags(tags);
	sql = String.format(sql, subselect);

an example of final sql is (if there are 3 tags)

select distinct cluster_id from host join 
( SELECT filtered.host_id, COUNT(filtered.tag) AS tag_count FROM (SELECT host_id, tag FROM host_tags GROUP BY host_id,tag) AS filtered WHERE tag IN(?,?,?) GROUP BY host_id HAVING tag_count = 3  ) AS selected_hosts 
ON host.id = selected_hosts.host_id;

[sureshanaparti]

LGTM