Adding memoryallocatedpercentage & memoryallocatedbytes to HostsResponse & HostsForMigrationResponse

[davidjumani]

Description

Fixes #4460

Adds memoryallocatedpercentage & memoryallocatedbytes to HostsResponse as well as HostsForMigrationResponse and deprecates memoryallocated

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

(localhost) 🐱 > list hosts filter=cpuallocated,memoryallocated,memoryallocatedbytes,memoryallocatedpercentage, type=Routing
{
  "count": 2,
  "host": [
    {
      "cpuallocated": "6.25%",
      "memoryallocated": 2415919104,
      "memoryallocatedbytes": 2415919104,
      "memoryallocatedpercentage": "28.12%"
    },
    {
      "cpuallocated": "1.56%",
      "memoryallocated": 536870912,
      "memoryallocatedbytes": 536870912,
      "memoryallocatedpercentage": "6.25%"
    }
  ]
}
(localhost) 🐱 > find hostsformigration virtualmachineid=e3c2c89a-26b3-427e-bc4a-34caeedf466a filter=cpuallocated,memoryallocated,memoryallocatedbytes,memoryallocatedpercentage, type=Routing
{
  "count": 2,
  "host": [
    {
      "cpuallocated": "1.56%",
      "memoryallocated": "6.25%",
      "memoryallocatedbytes": 536870912,
      "memoryallocatedpercentage": "6.25%"
    }
  ]
}

[davidjumani]

@blueorangutan package

[davidjumani]

@blueorangutan package

[blueorangutan]

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[davidjumani]

@weizhouapache Is it fine that the memory is numeric but CPU is in percentage ? Or would it be better to have new memoryallocaedpercentage & cpuallocaedpercentage fields ?

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2400

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[weizhouapache]

@weizhouapache Is it fine that the memory is numeric but CPU is in percentage ? Or would it be better to have new memoryallocaedpercentage & cpuallocaedpercentage fields ?

@davidjumani it would be better. but it might break backwards compatibility (hope few users will be impacted).

[blueorangutan]

Trillian test result (tid-3198)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30749 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4478-t3198-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[rohityadavcloud]

Will this cause regression?

[davidjumani]

It will but we can introduce two new fields memoryallocaedpercentage & cpuallocaedpercentage to compensate.
This will ensure that the response for both HostResponse and HostForMigrationResponse will be the same. Sounds good @rhtyd ?

[DaanHoogland]

€0,02: we can add responce parameters that are alligned for both -precentages and -values and leave these alone alltogether. @weizhouapache @rhtyd @davidjumani ?

[weizhouapache]

€0,02: we can add responce parameters that are alligned for both -precentages and -values and leave these alone alltogether. @weizhouapache @rhtyd @davidjumani ?

@DaanHoogland good to me. and mark the cpuallocated and memoryallocated as deprecated ?

[DaanHoogland]

€0,02: we can add responce parameters that are alligned for both -precentages and -values and leave these alone alltogether. @weizhouapache @rhtyd @davidjumani ?

@DaanHoogland good to me. and mark the cpuallocated and memoryallocated as deprecated ?

yes

[davidjumani]

€0,02: we can add responce parameters that are alligned for both -precentages and -values and leave these alone alltogether. @weizhouapache @rhtyd @davidjumani ?

@DaanHoogland good to me. and mark the cpuallocated and memoryallocated as deprecated ?

yes

Sounds good! I'll make the changes

[davidjumani]

@DaanHoogland @weizhouapache Added memoryallocatedpercentage & memoryallocatedbytes and deprecated memoryallocated

[DaanHoogland]

yes 👍 don't bother for now but I'm creating a ticket do implement the same for cpu #4488

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2413

[DaanHoogland]

I don't think we need smoke tests for this. restarted two of the travis runs