Skip to content

Conversation

@Spaceman1984
Copy link
Contributor

@Spaceman1984 Spaceman1984 commented Nov 3, 2020

Description

This PR adds compression to dnsmasq log files

Fixes: #3756

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Log into virtual router
Check /var/log/ directory, observe dnsmasq.log
Change system time 1 day ahead and reboot VR
Check /var/log/ directory, observe dnsmasq.log, dnsmasq.log1
Change system time 1 day ahead and reboot VR
There should be 3 log files now and 1 should be compressed
Check /var/log/ directory, observe dnsmasq.log, dnsmasq.log1, dnsmasq.log.2.gz

@Spaceman1984 Spaceman1984 changed the title Added compress option to dnsmasq Added compress option to dnsmasq log files Nov 3, 2020
@Spaceman1984
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2325

@Spaceman1984
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3119)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31996 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4439-t3119-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland added this to the 4.16.0.0 milestone Nov 4, 2020
@rohityadavcloud rohityadavcloud modified the milestones: 4.16.0.0, 4.15.0.0 Nov 4, 2020
@rohityadavcloud
Copy link
Member

Simple enough change, let's merge for master @DaanHoogland ?

@DaanHoogland
Copy link
Contributor

@PaulAngus merging this as it is small and not intrusive. cc @GabrielBrascher @weizhouapache.

@DaanHoogland DaanHoogland merged commit 88762c1 into apache:master Nov 6, 2020
@DaanHoogland DaanHoogland deleted the compress_dnsmasq_logfiles branch November 6, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dnsmasq log files are not compressed within virtual router

5 participants