Skip to content

Conversation

@ravening
Copy link
Member

@ravening ravening commented Oct 1, 2020

Description

We should have the metrics for the hosts which are dedicated to certain domains.
We should also be able to see cpu/memory/storage currently used per domain

Types of changes

  • Enhancement (improves an existing feature and functionality)

Screenshots (if appropriate):

How Has This Been Tested?

Enable prometheus server
Add 127.0.0.1 as allowed Ip so that you can fetch metrics from prometheus

Now fetch the endpoint

# http http://127.0.0.1:9595/metrics | grep cloudstack_host_is_dedicated
cloudstack_host_is_dedicated{zone="mgt122-10",hostname="node11",ip="10.13.122.11"} 1

# http http://127.0.0.1:9595/metrics | grep cloudstack_host_dedicated_to_account
cloudstack_host_dedicated_to_account{zone="mgt122-10",hostname="node11",ip="10.13.122.11"} 1

We should have the metrics for the
hosts which are dedicated to customers.
We should also be able to see cpu/memory/storage
currently used per domain
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test it

@rohityadavcloud rohityadavcloud added this to the 4.15.0.0 milestone Oct 1, 2020
@rohityadavcloud
Copy link
Member

Changes are strictly in the plugin code, merging this based on travis tests and 2x lgtms

@rohityadavcloud rohityadavcloud merged commit 191dbf7 into apache:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants