VMware: match hardware version for worker VM when taking a snapshot #4321

Spaceman1984 · 2020-09-11T13:07:48Z

Description

When a worker VM is created in the process of creating a volume snapshot on Vmware, the hardware version of the worker VM will be set to the highest supported hardware version of the hypervisor. If you have hypervisors of different versions in a cluster and have set the "Default VM compatibility" to a lower version, the worker VM should use the same version as the original VM instance,

This PR sets the worker VM hardware version to the same version as the original VM instance.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This has been tested by doing the following:

create an instance
take a snapshot
check the hardware version of the worker vm created in Vsphere.

Spaceman1984 · 2020-09-11T13:36:07Z

@blueorangutan package

blueorangutan · 2020-09-11T13:36:42Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-11T14:00:02Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1968

Spaceman1984 · 2020-09-11T14:17:08Z

@blueorangutan package

blueorangutan · 2020-09-11T14:18:18Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-11T14:51:33Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1969

Spaceman1984 · 2020-09-11T14:52:31Z

@blueorangutan ?

Spaceman1984 · 2020-09-11T14:52:55Z

@blueorangutan test ?

Spaceman1984 · 2020-09-11T14:53:05Z

@blueorangutan test

blueorangutan · 2020-09-11T14:53:42Z

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-09-12T12:09:21Z

Trillian test result (tid-2724)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 74400 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4321-t2724-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	`Error`	1808.86	test_kubernetes_supported_versions.py
test_02_vpc_privategw_static_routes	`Failure`	452.81	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	538.52	test_privategw_acl.py
test_hostha_kvm_host_fencing	`Error`	183.81	test_hostha_kvm.py

Spaceman1984 · 2020-09-14T07:44:08Z

@blueorangutan test ?

blueorangutan · 2020-09-14T07:45:13Z

@Spaceman1984 unsupported parameters provided. Supported mgmt server os are: centos6, centos7, centos8, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74

Spaceman1984 · 2020-09-14T07:46:47Z

@blueorangutan test centos7 vmware-65-u2

Spaceman1984 · 2020-09-14T07:47:12Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2020-09-14T07:48:17Z

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Spaceman1984 · 2020-09-14T11:23:50Z

@blueorangutan package

blueorangutan · 2020-09-14T11:25:12Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-14T12:00:05Z

Packaging result: ✖centos7 ✔centos8 ✔debian. JID-1994

Spaceman1984 · 2020-09-14T12:19:11Z

@blueorangutan package

blueorangutan · 2020-09-14T12:20:18Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-14T12:54:09Z

Packaging result: ✔centos7 ✔centos8 ✖debian. JID-1996

Spaceman1984 · 2020-09-14T12:58:11Z

@blueorangutan test centos7 vmware-65-u2

blueorangutan · 2020-09-14T12:59:13Z

@Spaceman1984 unsupported parameters provided. Supported mgmt server os are: centos6, centos7, centos8, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74

Spaceman1984 · 2020-09-14T13:02:51Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2020-09-14T13:04:13Z

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Spaceman1984 · 2020-09-15T07:19:58Z

@blueorangutan test centos7 vmware-65u2

rohityadavcloud · 2020-09-21T08:38:22Z

Please hold merging until someone can confirm manual testing cc @andrijapanicsb @borisstoyanov

…me and migrating a detached volume

rohityadavcloud · 2020-09-30T10:59:04Z

@blueorangutan package

blueorangutan · 2020-09-30T11:00:27Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

rohityadavcloud

LGTM, let's hold on merging until @borisstoyanov @andrijapanicsb can lgtm

blueorangutan · 2020-09-30T11:25:05Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2107

rohityadavcloud · 2020-09-30T11:40:49Z

@Spaceman1984 pl check, build failing due to possibly code or unit test failure

andrijapanicsb · 2020-09-30T13:26:54Z

The internal branch work is LGTM - if this PR is a duplicate of the same code - then let's assume LGTM.

Spaceman1984 · 2020-09-30T13:34:49Z

The branch builds fine locally, must be some kind of merge issue. Looking into it.

Spaceman1984 · 2020-09-30T13:36:02Z

@blueorangutan package

andrijapanicsb · 2020-09-30T13:36:25Z

I was advised that Alex will test cc @rhtyd

Spaceman1984 · 2020-10-01T08:28:03Z

@blueorangutan package

blueorangutan · 2020-10-01T08:28:37Z

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-10-01T08:59:41Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2108

Spaceman1984 · 2020-10-01T09:05:49Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2020-10-01T09:06:32Z

@Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

blueorangutan · 2020-10-01T20:32:51Z

Trillian test result (tid-2877)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39603 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4321-t2877-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	397.81	test_vpc_redundant.py

blueorangutan · 2020-10-06T18:59:04Z

Trillian test result (tid-2896)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35891 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4321-t2896-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Smoke tests completed. 85 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

alexandremattioli · 2020-10-07T10:07:46Z

Tested. LGTM

Add hardware version to worker VM

2aa4495

Spaceman1984 closed this Sep 11, 2020

Spaceman1984 reopened this Sep 11, 2020

rohityadavcloud requested a review from borisstoyanov September 21, 2020 08:37

DaanHoogland marked this pull request as draft September 21, 2020 10:45

Added worker VM hardware version when creating a template from a volu…

653e1a7

…me and migrating a detached volume

rohityadavcloud approved these changes Sep 30, 2020

View reviewed changes

rohityadavcloud marked this pull request as ready for review October 1, 2020 07:28

rohityadavcloud marked this pull request as draft October 1, 2020 07:29

Spaceman1984 added 2 commits October 1, 2020 09:56

Merge branch 'master' into snapshot_hw_version

836fbb0

Add null parameter back that was removed by merge

5bd9e71

Spaceman1984 closed this Oct 1, 2020

Spaceman1984 reopened this Oct 1, 2020

andrijapanicsb marked this pull request as ready for review October 9, 2020 15:05

andrijapanicsb merged commit 479ef8a into apache:master Oct 9, 2020

DaanHoogland added the Severity:Major label Nov 10, 2020

VMware: match hardware version for worker VM when taking a snapshot #4321

VMware: match hardware version for worker VM when taking a snapshot #4321

Uh oh!

Conversation

Spaceman1984 commented Sep 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Spaceman1984 commented Sep 11, 2020

Uh oh!

blueorangutan commented Sep 11, 2020

Uh oh!

blueorangutan commented Sep 11, 2020

Uh oh!

Spaceman1984 commented Sep 11, 2020

Uh oh!

blueorangutan commented Sep 11, 2020

Uh oh!

blueorangutan commented Sep 11, 2020

Uh oh!

Spaceman1984 commented Sep 11, 2020

Uh oh!

Spaceman1984 commented Sep 11, 2020

Uh oh!

Spaceman1984 commented Sep 11, 2020

Uh oh!

blueorangutan commented Sep 11, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

Spaceman1984 commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

Spaceman1984 commented Sep 14, 2020

Uh oh!

Spaceman1984 commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

Spaceman1984 commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

Spaceman1984 commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

Spaceman1984 commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

Spaceman1984 commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

Spaceman1984 commented Sep 15, 2020

Uh oh!

rohityadavcloud commented Sep 21, 2020

Uh oh!

rohityadavcloud commented Sep 30, 2020

Uh oh!

blueorangutan commented Sep 30, 2020

Uh oh!

rohityadavcloud left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Sep 30, 2020

Uh oh!

rohityadavcloud commented Sep 30, 2020

Uh oh!

andrijapanicsb commented Sep 30, 2020

Uh oh!

Spaceman1984 commented Sep 11, 2020 •

edited

Loading

alexandremattioli commented Oct 7, 2020 •

edited

Loading