Skip to content

Fixed guest vlan range going missing when using zone wizard #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrijapanicsb merged 1 commit into from
Apr 23, 2020
Merged

Fixed guest vlan range going missing when using zone wizard #4042

andrijapanicsb merged 1 commit into from
Apr 23, 2020

Conversation

@Spaceman1984
Copy link
Contributor

@Spaceman1984 Spaceman1984 commented Apr 23, 2020

Description

Fixes #4039 - Guest Vlan range will be lost when deploying ZONE

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

This has been tested by creating an advanced zone with the wizard and then checking if the vlan range was set for guest traffic on the physical network.

DaanHoogland
DaanHoogland approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@andrijapanicsb andrijapanicsb added this to the 4.13.1.0 milestone Apr 23, 2020
@borisstoyanov
Copy link
Contributor

borisstoyanov commented Apr 23, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 23, 2020

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 23, 2020

Packaging result: ✔centos7 ✔debian. JID-1191

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Apr 23, 2020

Screenshot 2020-04-23 at 16 38 02
LGTM

@andrijapanicsb
Copy link
Contributor

andrijapanicsb commented Apr 23, 2020

2 x LGTMs, functional/manul test OK - regression tests not needed since a simple JS changes.

Merging

@andrijapanicsb andrijapanicsb merged commit 7b7caf5 into apache:4.13 Apr 23, 2020
DaanHoogland added a commit that referenced this pull request Apr 23, 2020
@DaanHoogland
Merge release branch 4.13 to master
689e529 
* 4.13:
  Fixed guest vlan range going missing when using zone wizzard (#4042)
  Volume migration (#4043)
@andrijapanicsb andrijapanicsb mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:UI type:bug

Projects

None yet

Milestone

4.13.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Spaceman1984 @borisstoyanov @blueorangutan @andrijapanicsb @DaanHoogland @svenvogel