Skip to content

Conversation

@ustcweizhou
Copy link
Contributor

Description

For customer constrained offering, the cpu speed is fixed.
Therefore the 'CpuSpeed' field should be hidden for customer constrained offering when change vm offering on UI.
It is visible only for unconstrained offering.

This is regression issue of #3245

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@yadvr
Copy link
Member

yadvr commented Mar 30, 2020

@shwstppr
Copy link
Contributor

@ustcweizhou This is in vm deploy wizard?
I'm not able to reproduce any problem with 4.13 in UI.
CPU speed field is already hidden for Custom Constrained type offerings. Even after selecting an unconstrained offering then again selecting constrained offering. How to reproduce the problem?

@weizhouapache
Copy link
Member

@ustcweizhou This is in vm deploy wizard?
I'm not able to reproduce any problem with 4.13 in UI.
CPU speed field is already hidden for Custom Constrained type offerings. Even after selecting an unconstrained offering then again selecting constrained offering. How to reproduce the problem?

@shwstppr as I mentioned in the description, this issue happens when change vm offering.

@yadvr yadvr added this to the 4.13.2.0 milestone Jun 11, 2020
@yadvr yadvr changed the base branch from 4.13 to 4.14 August 28, 2020 09:07
@yadvr yadvr modified the milestones: 4.13.2.0, 4.14.1.0 Aug 28, 2020
@yadvr yadvr changed the base branch from 4.14 to 4.13 August 28, 2020 09:07
@yadvr yadvr modified the milestones: 4.14.1.0, 4.13.2.0 Aug 28, 2020
@yadvr
Copy link
Member

yadvr commented Aug 28, 2020

Since this is a UI only change no smoketests are necessary. All new changes are in Primate now, legacy UI need not be maintained anymore.
LGTM, I'll merge on 4.13 and fwd merge on 4.14 and master.

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code changes

@yadvr yadvr merged commit ba4b04f into apache:4.13 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants