Skip to content

Conversation

@ravening
Copy link
Member

@ravening ravening commented Feb 4, 2020

Description

When the state of the site to site vpn changes, the check
is done on all the virtual routers including the internal
load balancing vm as well. It is not needed to check the
state for internal load balancing vm

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Steps to reprodcue the issue

1 . Create two VPC's. Configure VPN customer gateway and VPN connection. The steps are clearly explained here
2 . Now navigate to networks section in main cloudstack ui. In the drop down menu select VPC. Click configure on one of the VPC
3 . Click on "Create Network" and create a tier with "DefaultisolatedNetworkOfferingForVPCNetworksWithInternalLB" network offering
4 . Once the tier is created click on "Internal LB" tab.
5 . In the right side, click on "Add Internal LB" button
6 . Enter the input according to your needs and press OK
7 . Once the Internal LB is created, click on it and select the "Assigned VM's" tab.
8 . Click on "Assign VM's" button and select the VM's which are present in this tier. If none are present then create vm's.
9 . This will create a new type of router "internallb" which can be listed using the cloudmonkey command "list internalloadbalancervms" whose name starts with b-
10 . Change the state of any VPN connection in this VPC and observe the logs for the keyword "Site-to-site Vpn Connection to on router b-<>-VM"

Expected result:

A log mesasge mentioned in the step 10 will be displayed in /var/log/cloudstack/management/management-server.log

Actual result:

The above log should not be displayed.

@yadvr yadvr added this to the 4.14.0.0 milestone Feb 6, 2020
@andrijapanicsb andrijapanicsb self-requested a review February 7, 2020 12:39
@andrijapanicsb
Copy link
Contributor

@ravening since this is a bug fix, do you mind rebasing against 4.13 so we can merge it there and merge forward to master afterwards?

@yadvr
Copy link
Member

yadvr commented Feb 12, 2020

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@ravening ravening force-pushed the ignore_s2s_status_ilb branch from 164f984 to 4630e85 Compare February 12, 2020 09:30
@blueorangutan
Copy link

Packaging result: ✖centos6 ✖centos7 ✔debian. JID-817

When the state of the site to site vpn changes, the check
is done on all the virtual routers including the internal
load balancing vm as well. It is not needed to check the
state for internal load balancing vm
@ravening ravening force-pushed the ignore_s2s_status_ilb branch from 4630e85 to 2215f8b Compare February 12, 2020 10:04
@ravening ravening changed the base branch from master to 4.13 February 12, 2020 10:08
@ravening
Copy link
Member Author

@ravening since this is a bug fix, do you mind rebasing against 4.13 so we can merge it there and merge forward to master afterwards?

Rebased to 4.13

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@yadvr yadvr closed this Feb 12, 2020
@yadvr yadvr reopened this Feb 12, 2020
@yadvr
Copy link
Member

yadvr commented Feb 12, 2020

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-839

@yadvr
Copy link
Member

yadvr commented Feb 12, 2020

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-963)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31658 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3864-t963-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_migration.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 34 look OK, 39 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestLoadBalance>:setup Error 0.00 test_loadbalance.py
test_list_vms_metrics Error 0.16 test_metrics_api.py
test_01_native_to_native_network_migration Error 4.32 test_migration.py
test_02_native_to_native_vpc_migration Error 6.04 test_migration.py
ContextSuite context=TestInternalLb>:setup Error 0.00 test_internal_lb.py
ContextSuite context=TestNetworkACL>:setup Error 0.00 test_network_acl.py
test_01_1_create_iso_with_checksum_sha1_negative Error 66.58 test_iso.py
test_01_create_iso_with_checksum_sha1 Error 65.50 test_iso.py
test_01_create_iso_with_checksum_sha1 Error 66.59 test_iso.py
test_02_1_create_iso_with_checksum_sha256_negative Error 66.58 test_iso.py
test_02_create_iso_with_checksum_sha256 Error 65.50 test_iso.py
test_02_create_iso_with_checksum_sha256 Error 66.58 test_iso.py
test_03_1_create_iso_with_checksum_md5_negative Error 66.58 test_iso.py
test_03_create_iso_with_checksum_md5 Error 65.49 test_iso.py
test_03_create_iso_with_checksum_md5 Error 66.57 test_iso.py
test_04_create_iso_with_no_checksum Error 65.50 test_iso.py
test_04_create_iso_with_no_checksum Error 66.59 test_iso.py
test_01_create_iso Failure 1514.61 test_iso.py
ContextSuite context=TestISO>:setup Error 3030.32 test_iso.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
test_nic_secondaryip_add_remove Error 0.08 test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup Error 0.00 test_nested_virtualization.py
test_delete_account Error 0.78 test_network.py
test_delete_network_while_vm_on_it Error 0.08 test_network.py
test_deploy_vm_l2network Error 0.09 test_network.py
test_l2network_restart Error 1.29 test_network.py
ContextSuite context=TestPortForwarding>:setup Error 3.60 test_network.py
ContextSuite context=TestPublicIP>:setup Error 5.38 test_network.py
test_reboot_router Error 0.07 test_network.py
test_releaseIP Error 0.76 test_network.py
ContextSuite context=TestRouterRules>:setup Error 0.86 test_network.py
test_01_nic Error 2.46 test_nic.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup Error 0.00 test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup Error 0.00 test_portforwardingrules.py
test_01_add_primary_storage_disabled_host Error 0.22 test_primary_storage.py
test_01_primary_storage_nfs Error 0.17 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.31 test_primary_storage.py
ContextSuite context=TestPrivateGwACL>:setup Error 0.00 test_privategw_acl.py
test_09_project_suspend Error 1.12 test_projects.py
test_10_project_activation Error 1.09 test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup Error 0.00 test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup Error 0.00 test_resource_accounting.py
test_01_sys_vm_start Failure 0.10 test_secondary_storage.py
ContextSuite context=TestRouterDHCPHosts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup Error 0.00 test_router_dns.py
ContextSuite context=TestCpuCapServiceOfferings>:setup Error 0.00 test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup Error 0.24 test_service_offerings.py
ContextSuite context=TestRouterDnsService>:setup Error 0.00 test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup Error 0.00 test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup Error 0.00 test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true Error 0.24 test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false Error 0.24 test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup Error 1.47 test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup Error 0.00 test_routers.py
ContextSuite context=TestSnapshotRootDisk>:setup Error 0.00 test_snapshots.py
test_03_ssvm_internals Error 935.56 test_ssvm.py
test_04_cpvm_internals Error 940.10 test_ssvm.py
test_05_stop_ssvm Error 1.23 test_ssvm.py
test_06_stop_cpvm Error 2.20 test_ssvm.py
test_07_reboot_ssvm Error 911.41 test_ssvm.py
test_08_reboot_cpvm Error 911.53 test_ssvm.py
test_09_destroy_ssvm Error 2.17 test_ssvm.py
test_10_destroy_cpvm Error 2.19 test_ssvm.py
test_02_create_template_with_checksum_sha1 Error 65.51 test_templates.py
test_03_create_template_with_checksum_sha256 Error 65.52 test_templates.py
test_04_create_template_with_checksum_md5 Error 65.50 test_templates.py
test_05_create_template_with_no_checksum Error 65.51 test_templates.py
test_01_register_template_direct_download_flag Error 0.06 test_templates.py
test_02_deploy_vm_from_direct_download_template Error 0.00 test_templates.py
test_03_deploy_vm_wrong_checksum Error 0.05 test_templates.py
ContextSuite context=TestTemplates>:setup Error 5.05 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestLBRuleUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestNatRuleUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestPublicIPUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestSnapshotUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestVmUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestVolumeUsage>:setup Error 0.00 test_usage.py
ContextSuite context=TestVpnUsage>:setup Error 0.00 test_usage.py
test_01_deploy_vm_on_specific_host Error 2.39 test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster Error 1.24 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 1.29 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 1.32 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 1.26 test_vm_deployment_planner.py
ContextSuite context=Test01DeployVM>:setup Error 0.00 test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup Error 0.00 test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration Error 0.02 test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration Error 0.02 test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration Error 0.01 test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup Error 2.10 test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup Error 0.00 test_volumes.py
ContextSuite context=TestVolumes>:setup Error 0.00 test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup Error 0.00 test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup Error 0.00 test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
test_01_cancel_host_maintenace_with_no_migration_jobs Failure 0.16 test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs Error 2.64 test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected Error 0.03 test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected Error 0.02 test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected Error 0.02 test_host_maintenance.py
test_hostha_enable_ha_when_host_disconected Error 937.05 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 302.79 test_hostha_kvm.py

@yadvr
Copy link
Member

yadvr commented Feb 12, 2020

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-983)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36042 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3864-t983-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 206.47 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 205.04 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 307.08 test_privategw_acl.py

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@DaanHoogland DaanHoogland reopened this Feb 13, 2020
@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-855

@yadvr yadvr closed this Feb 14, 2020
@yadvr yadvr reopened this Feb 14, 2020
@yadvr
Copy link
Member

yadvr commented Feb 14, 2020

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-870

@apache apache deleted a comment from blueorangutan Feb 14, 2020
@DaanHoogland DaanHoogland modified the milestones: 4.14.0.0, 4.13.1.0 Feb 14, 2020
@DaanHoogland DaanHoogland reopened this Feb 14, 2020
@yadvr
Copy link
Member

yadvr commented Feb 17, 2020

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr
Copy link
Member

yadvr commented Feb 17, 2020

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr
Copy link
Member

yadvr commented Feb 17, 2020

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1013)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56142 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3864-t1013-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 66 look OK, 11 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_port_fwd_on_src_nat Failure 813.96 test_network.py
test_02_port_fwd_on_non_src_nat Failure 816.08 test_network.py
test_reboot_router Failure 397.13 test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule Failure 815.04 test_network.py
test_network_rules_acquired_public_ip_2_nat_rule Failure 816.61 test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule Failure 819.73 test_network.py
test_isolate_network_password_server Failure 216.62 test_password_server.py
test_02_vpc_privategw_static_routes Failure 942.59 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 941.82 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 996.95 test_privategw_acl.py
test_router_dhcphosts Failure 216.57 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardown Error 225.82 test_router_dhcphosts.py
test_router_dns_guestipquery Failure 613.54 test_router_dns.py
test_router_dns_guestipquery Failure 613.79 test_router_dnsservice.py
test_01_single_VPC_iptables_policies Error 916.62 test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true Failure 261.04 test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false Failure 261.01 test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failure 285.13 test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failure 287.15 test_routers_network_ops.py
test_01_service_offering_cpu_limit_use Error 811.23 test_service_offerings.py
test_04_change_offering_small Failure 910.99 test_service_offerings.py
test_04_extract_template Failure 128.27 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py

@yadvr
Copy link
Member

yadvr commented Feb 18, 2020

I checked some issue at the backend. Considering the test on #3864 (comment) LGTM.

@yadvr yadvr merged commit bbe2bf1 into apache:4.13 Feb 18, 2020
nvazquez pushed a commit to shapeblue/cloudstack that referenced this pull request Feb 21, 2020
…3864)

When the state of the site to site vpn changes, the check
is done on all the virtual routers including the internal
load balancing vm as well. It is not needed to check the
state for internal load balancing vm
nvazquez pushed a commit to shapeblue/cloudstack that referenced this pull request Feb 21, 2020
…3864)

When the state of the site to site vpn changes, the check
is done on all the virtual routers including the internal
load balancing vm as well. It is not needed to check the
state for internal load balancing vm
ggoodrich-ipp pushed a commit to ippathways/cloudstack that referenced this pull request Feb 24, 2020
…3864)

When the state of the site to site vpn changes, the check
is done on all the virtual routers including the internal
load balancing vm as well. It is not needed to check the
state for internal load balancing vm
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
…3864)

When the state of the site to site vpn changes, the check
is done on all the virtual routers including the internal
load balancing vm as well. It is not needed to check the
state for internal load balancing vm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants