-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Ignore site to site vpn status check on internallbvm #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
Outdated
Show resolved
Hide resolved
|
@ravening since this is a bug fix, do you mind rebasing against 4.13 so we can merge it there and merge forward to master afterwards? |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
164f984 to
4630e85
Compare
|
Packaging result: ✖centos6 ✖centos7 ✔debian. JID-817 |
When the state of the site to site vpn changes, the check is done on all the virtual routers including the internal load balancing vm as well. It is not needed to check the state for internal load balancing vm
4630e85 to
2215f8b
Compare
Rebased to 4.13 |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-839 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-963)
|
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-983)
|
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-855 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-870 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1013)
|
|
I checked some issue at the backend. Considering the test on #3864 (comment) LGTM. |
…3864) When the state of the site to site vpn changes, the check is done on all the virtual routers including the internal load balancing vm as well. It is not needed to check the state for internal load balancing vm
…3864) When the state of the site to site vpn changes, the check is done on all the virtual routers including the internal load balancing vm as well. It is not needed to check the state for internal load balancing vm
…3864) When the state of the site to site vpn changes, the check is done on all the virtual routers including the internal load balancing vm as well. It is not needed to check the state for internal load balancing vm
…3864) When the state of the site to site vpn changes, the check is done on all the virtual routers including the internal load balancing vm as well. It is not needed to check the state for internal load balancing vm
Description
When the state of the site to site vpn changes, the check
is done on all the virtual routers including the internal
load balancing vm as well. It is not needed to check the
state for internal load balancing vm
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Steps to reprodcue the issue
1 . Create two VPC's. Configure VPN customer gateway and VPN connection. The steps are clearly explained here
2 . Now navigate to networks section in main cloudstack ui. In the drop down menu select VPC. Click configure on one of the VPC
3 . Click on "Create Network" and create a tier with "DefaultisolatedNetworkOfferingForVPCNetworksWithInternalLB" network offering
4 . Once the tier is created click on "Internal LB" tab.
5 . In the right side, click on "Add Internal LB" button
6 . Enter the input according to your needs and press OK
7 . Once the Internal LB is created, click on it and select the "Assigned VM's" tab.
8 . Click on "Assign VM's" button and select the VM's which are present in this tier. If none are present then create vm's.
9 . This will create a new type of router "internallb" which can be listed using the cloudmonkey command "list internalloadbalancervms" whose name starts with b-
10 . Change the state of any VPN connection in this VPC and observe the logs for the keyword "Site-to-site Vpn Connection to on router b-<>-VM"
Expected result:
A log mesasge mentioned in the step 10 will be displayed in /var/log/cloudstack/management/management-server.log
Actual result:
The above log should not be displayed.