Skip to content

Conversation

@csquire
Copy link
Contributor

@csquire csquire commented Nov 5, 2018

Description

Updated ApiServiceDiscoveryImpl to check superclasses of API responses for fields.

Fixes: #3002

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • [x ] Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Additional unit test and tested locally to verify the tags field was present in the output of listApis response for listVirtualMachines API.

@DaanHoogland DaanHoogland requested a review from nvazquez November 6, 2018 09:55
response.setRelated(responseName);

Field[] responseFields = apiCmdAnnotation.responseObject().getDeclaredFields();
List<Field> responseFields = new ArrayList<>(Arrays.asList(responseClass.getDeclaredFields()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing this whole loop thing, what about using org.reflections.ReflectionUtils.getAllFields(Class<?>)? It will produce the same result with much less code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

@csquire csquire force-pushed the 3002_listapis_missing_tags_field branch from d15243e to 70a3075 Compare November 7, 2018 14:29
@yadvr
Copy link
Member

yadvr commented Nov 28, 2018

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2470

@yadvr
Copy link
Member

yadvr commented Nov 28, 2018

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3232)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24535 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3005-t3232-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 65 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_extract_template Failure 128.34 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
test_06_download_detached_volume Failure 137.45 test_volumes.py

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, based on test results

@yadvr yadvr merged commit 290df5f into apache:4.11 Dec 4, 2018
@yadvr
Copy link
Member

yadvr commented Dec 4, 2018

Lgtm, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants