Skip to content

CLOUDSTACK-9831: Previous pod_id still remains in the vm_instance table #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karuturi merged 1 commit into from
May 17, 2017
Merged

CLOUDSTACK-9831: Previous pod_id still remains in the vm_instance table #2002

karuturi merged 1 commit into from
May 17, 2017

Conversation

@sudhansu7
Copy link

@sudhansu7 sudhansu7 commented Mar 13, 2017 •
edited
Loading

Previous pod_id still remains in the vm_instance table after VM migration with migrateVirtualMachineWithVolume


Previous pod_id still remains in the vm_instance table after VM migration with migrateVirtualMachineWithVolume

Before migrateVirtualMachineWithVolume
mysql> select v.id,v.instance_name,h.name,v.pod_id as pod_id_from_instance_tb,h.pod_id as pod_id_from_host_tb from vm_instance v, host h where v.host_id=h.id and v.id=2;
------------------------------------------------------------------------------------------------------
id 	instance_name 	name 	pod_id_from_instance_tb 	pod_id_from_host_tb

------------------------------------------------------------------------------------------------------
2 	i-2-2-VM 	testVM 	1 	1

------------------------------------------------------------------------------------------------------
1 row in set (0.00 sec)

After migrateVirtualMachineWithVolume
mysql> select v.id,v.instance_name,h.name,v.pod_id as pod_id_from_instance_tb,h.pod_id as pod_id_from_host_tb from vm_instance v, host h where v.host_id=h.id and v.id=3;
-----------------------------------------------------------------------------------------------------
id 	instance_name 	name 	pod_id_from_instance_tb 	pod_id_from_host_tb

-----------------------------------------------------------------------------------------------------
3 	i-2-3-VM 	testVm1 	1 	2

-----------------------------------------------------------------------------------------------------
1 row in set (0.00 sec)

@serg38
Copy link

serg38 commented Mar 13, 2017

@sudhansu7 Shouldn't we update POD id upon a successful migration? If migration fails we will have wrong POD id in the DB.

@sudhansu7 sudhansu7 force-pushed the CLOUDSTACK-9831 branch 2 times, most recently from d3aac19 to 46b74ae Compare March 30, 2017 11:11
@sudhansu7
Copy link
Author

sudhansu7 commented Mar 30, 2017

@serg38
Added changes for failure case. If migration fails the old pod id will be restored.

@SudharmaJain
Copy link
Contributor

SudharmaJain commented Mar 30, 2017

LGTM on the code changes.

@serg38
Copy link

serg38 commented Mar 30, 2017

LGTM on the code review. @borisstoyanov @rhtyd Can you kick off tests for this PR?

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Mar 30, 2017

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 30, 2017

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 30, 2017

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-607

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Mar 31, 2017

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 31, 2017

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Mar 31, 2017

Trillian test result (tid-971)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34464 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2002-t971-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)

Test Result Time (s) Test File
test_04_rvpc_privategw_static_routes Failure 345.59 test_privategw_acl.py
test_03_migration_options_storage_tags Error 0.38 test_primary_storage.py
test_01_vpc_site2site_vpn Success 159.91 test_vpc_vpn.py
test_01_vpc_remote_access_vpn Success 66.11 test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn Success 245.85 test_vpc_vpn.py
test_02_VPC_default_routes Success 274.06 test_vpc_router_nics.py
test_01_VPC_nics_after_destroy Success 543.27 test_vpc_router_nics.py
test_05_rvpc_multi_tiers Success 510.48 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Success 1404.52 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Success 548.38 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Success 752.06 test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Success 1299.77 test_vpc_redundant.py
test_09_delete_detached_volume Success 152.07 test_volumes.py
test_08_resize_volume Success 156.61 test_volumes.py
test_07_resize_fail Success 161.54 test_volumes.py
test_06_download_detached_volume Success 156.29 test_volumes.py
test_05_detach_volume Success 155.77 test_volumes.py
test_04_delete_attached_volume Success 151.18 test_volumes.py
test_03_download_attached_volume Success 156.34 test_volumes.py
test_02_attach_volume Success 94.85 test_volumes.py
test_01_create_volume Success 711.23 test_volumes.py
test_03_delete_vm_snapshots Success 275.21 test_vm_snapshots.py
test_02_revert_vm_snapshots Success 95.75 test_vm_snapshots.py
test_01_create_vm_snapshots Success 158.86 test_vm_snapshots.py
test_deploy_vm_multiple Success 247.65 test_vm_life_cycle.py
test_deploy_vm Success 0.05 test_vm_life_cycle.py
test_advZoneVirtualRouter Success 0.02 test_vm_life_cycle.py
test_10_attachAndDetach_iso Success 26.66 test_vm_life_cycle.py
test_09_expunge_vm Success 125.19 test_vm_life_cycle.py
test_08_migrate_vm Success 40.90 test_vm_life_cycle.py
test_07_restore_vm Success 0.13 test_vm_life_cycle.py
test_06_destroy_vm Success 125.83 test_vm_life_cycle.py
test_03_reboot_vm Success 125.85 test_vm_life_cycle.py
test_02_start_vm Success 10.17 test_vm_life_cycle.py
test_01_stop_vm Success 40.33 test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName Success 36.02 test_templates.py
test_08_list_system_templates Success 0.04 test_templates.py
test_07_list_public_templates Success 0.04 test_templates.py
test_05_template_permissions Success 0.06 test_templates.py
test_04_extract_template Success 5.13 test_templates.py
test_03_delete_template Success 5.11 test_templates.py
test_02_edit_template Success 90.12 test_templates.py
test_01_create_template Success 40.51 test_templates.py
test_10_destroy_cpvm Success 166.65 test_ssvm.py
test_09_destroy_ssvm Success 138.63 test_ssvm.py
test_08_reboot_cpvm Success 131.61 test_ssvm.py
test_07_reboot_ssvm Success 133.58 test_ssvm.py
test_06_stop_cpvm Success 131.76 test_ssvm.py
test_05_stop_ssvm Success 163.71 test_ssvm.py
test_04_cpvm_internals Success 1.23 test_ssvm.py
test_03_ssvm_internals Success 3.28 test_ssvm.py
test_02_list_cpvm_vm Success 0.13 test_ssvm.py
test_01_list_sec_storage_vm Success 0.14 test_ssvm.py
test_02_list_snapshots_with_removed_data_store Success 81.92 test_snapshots.py
test_01_snapshot_root_disk Success 11.25 test_snapshots.py
test_04_change_offering_small Success 234.52 test_service_offerings.py
test_03_delete_service_offering Success 0.04 test_service_offerings.py
test_02_edit_service_offering Success 0.06 test_service_offerings.py
test_01_create_service_offering Success 0.11 test_service_offerings.py
test_02_sys_template_ready Success 0.13 test_secondary_storage.py
test_01_sys_vm_start Success 0.20 test_secondary_storage.py
test_09_reboot_router Success 35.33 test_routers.py
test_08_start_router Success 30.28 test_routers.py
test_07_stop_router Success 10.16 test_routers.py
test_06_router_advanced Success 0.06 test_routers.py
test_05_router_basic Success 0.04 test_routers.py
test_04_restart_network_wo_cleanup Success 5.69 test_routers.py
test_03_restart_network_cleanup Success 55.51 test_routers.py
test_02_router_internal_adv Success 1.01 test_routers.py
test_01_router_internal_basic Success 0.57 test_routers.py
test_router_dns_guestipquery Success 76.93 test_router_dns.py
test_router_dns_externalipquery Success 0.08 test_router_dns.py
test_router_dhcphosts Success 277.18 test_router_dhcphosts.py
test_router_dhcp_opts Success 21.78 test_router_dhcphosts.py
test_01_updatevolumedetail Success 0.12 test_resource_detail.py
test_01_reset_vm_on_reboot Success 131.50 test_reset_vm_on_reboot.py
test_createRegion Success 0.06 test_regions.py
test_create_pvlan_network Success 5.23 test_pvlan.py
test_dedicatePublicIpRange Success 0.42 test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup Success 489.85 test_privategw_acl.py
test_02_vpc_privategw_static_routes Success 360.23 test_privategw_acl.py
test_01_vpc_privategw_acl Success 92.19 test_privategw_acl.py
test_02_edit_primary_storage_tags Success 0.09 test_primary_storage.py
test_01_primary_storage_nfs Success 35.77 test_primary_storage.py
test_01_deploy_vms_storage_tags Success 31.01 test_primary_storage.py
test_createPortablePublicIPRange Success 15.20 test_portable_publicip.py
test_createPortablePublicIPAcquire Success 15.50 test_portable_publicip.py
test_isolate_network_password_server Success 89.46 test_password_server.py
test_UpdateStorageOverProvisioningFactor Success 0.14 test_over_provisioning.py
test_oobm_zchange_password Success 30.80 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Success 16.32 test_outofbandmanagement.py
test_oobm_issue_power_status Success 10.26 test_outofbandmanagement.py
test_oobm_issue_power_soft Success 15.62 test_outofbandmanagement.py
test_oobm_issue_power_reset Success 25.45 test_outofbandmanagement.py
test_oobm_issue_power_on Success 15.34 test_outofbandmanagement.py
test_oobm_issue_power_off Success 15.31 test_outofbandmanagement.py
test_oobm_issue_power_cycle Success 15.31 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Success 92.66 test_outofbandmanagement.py
test_oobm_enable_feature_valid Success 5.16 test_outofbandmanagement.py
test_oobm_enable_feature_invalid Success 0.10 test_outofbandmanagement.py
test_oobm_disable_feature_valid Success 5.18 test_outofbandmanagement.py
test_oobm_disable_feature_invalid Success 0.10 test_outofbandmanagement.py
test_oobm_configure_invalid_driver Success 0.08 test_outofbandmanagement.py
test_oobm_configure_default_driver Success 0.07 test_outofbandmanagement.py
test_oobm_background_powerstate_sync Success 23.40 test_outofbandmanagement.py
test_extendPhysicalNetworkVlan Success 15.34 test_non_contigiousvlan.py
test_01_nic Success 429.18 test_nic.py
test_releaseIP Success 247.85 test_network.py
test_reboot_router Success 409.05 test_network.py
test_public_ip_user_account Success 10.24 test_network.py
test_public_ip_admin_account Success 40.29 test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule Success 72.05 test_network.py
test_network_rules_acquired_public_ip_2_nat_rule Success 62.28 test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule Success 123.86 test_network.py
test_delete_account Success 277.77 test_network.py
test_02_port_fwd_on_non_src_nat Success 55.65 test_network.py
test_01_port_fwd_on_src_nat Success 111.82 test_network.py
test_nic_secondaryip_add_remove Success 212.69 test_multipleips_per_nic.py
login_test_saml_user Success 19.27 test_login.py
test_assign_and_removal_lb Success 133.33 test_loadbalance.py
test_02_create_lb_rule_non_nat Success 187.17 test_loadbalance.py
test_01_create_lb_rule_src_nat Success 208.53 test_loadbalance.py
test_03_list_snapshots Success 0.06 test_list_ids_parameter.py
test_02_list_templates Success 0.04 test_list_ids_parameter.py
test_01_list_volumes Success 0.03 test_list_ids_parameter.py
test_07_list_default_iso Success 0.06 test_iso.py
test_05_iso_permissions Success 0.07 test_iso.py
test_04_extract_Iso Success 5.18 test_iso.py
test_03_delete_iso Success 95.16 test_iso.py
test_02_edit_iso Success 0.06 test_iso.py
test_01_create_iso Success 21.16 test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Success 198.00 test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Success 143.32 test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Success 495.54 test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Success 418.06 test_internal_lb.py
test_dedicateGuestVlanRange Success 10.29 test_guest_vlan_range.py
test_UpdateConfigParamWithScope Success 0.14 test_global_settings.py
test_rolepermission_lifecycle_update Success 6.19 test_dynamicroles.py
test_rolepermission_lifecycle_list Success 5.99 test_dynamicroles.py
test_rolepermission_lifecycle_delete Success 5.92 test_dynamicroles.py
test_rolepermission_lifecycle_create Success 5.92 test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates Success 6.00 test_dynamicroles.py
test_role_lifecycle_update_role_inuse Success 5.92 test_dynamicroles.py
test_role_lifecycle_update Success 10.98 test_dynamicroles.py
test_role_lifecycle_list Success 5.89 test_dynamicroles.py
test_role_lifecycle_delete Success 10.93 test_dynamicroles.py
test_role_lifecycle_create Success 5.92 test_dynamicroles.py
test_role_inuse_deletion Success 5.88 test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers Success 8.19 test_dynamicroles.py
test_role_account_acls Success 8.25 test_dynamicroles.py
test_default_role_deletion Success 6.04 test_dynamicroles.py
test_04_create_fat_type_disk_offering Success 0.07 test_disk_offerings.py
test_03_delete_disk_offering Success 0.04 test_disk_offerings.py
test_02_edit_disk_offering Success 0.05 test_disk_offerings.py
test_02_create_sparse_type_disk_offering Success 0.07 test_disk_offerings.py
test_01_create_disk_offering Success 0.11 test_disk_offerings.py
test_deployvm_userdispersing Success 20.89 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated Success 20.66 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit Success 75.83 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post Success 10.38 test_deploy_vm_with_userdata.py
test_deployvm_userdata Success 65.86 test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize Success 6.04 test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize Success 5.99 test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize Success 207.34 test_deploy_vm_root_resize.py
test_deploy_vm_from_iso Success 207.66 test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup Success 66.01 test_affinity_groups.py
test_change_service_offering_for_vm_with_snapshots Skipped 0.00 test_vm_snapshots.py
test_01_test_vm_volume_snapshot Skipped 0.00 test_vm_snapshots.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.02 test_staticroles.py
test_11_ss_nfs_version_on_ssvm Skipped 0.02 test_ssvm.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.04 test_primary_storage.py
test_nested_virtualization_vmware Skipped 0.00 test_nested_virtualization.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_deploy_vgpu_enabled_vm Skipped 0.03 test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support Skipped 0.04 test_deploy_vgpu_enabled_vm.py

borisstoyanov
borisstoyanov approved these changes Apr 2, 2017
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marvin tests results and code changes LGTM

CLOUDSTACK-9831: Previous pod_id still remains in the vm_instance tab…
3564d30 
…le after

 VM migration with migrateVirtualMachineWithVolume
@sudhansu7
Copy link
Author

sudhansu7 commented Apr 27, 2017

tag:mergeready

@yadvr
Copy link
Member

yadvr commented May 15, 2017

@sudhansu7 can you change the base branch to 4.9 please, otherwise LGTM

@karuturi karuturi added this to the 4.10.0.0 milestone May 17, 2017
@karuturi karuturi merged commit 6dd2ebe into apache:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

type:bug

Projects

None yet

Milestone

4.10.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@sudhansu7 @serg38 @SudharmaJain @borisstoyanov @blueorangutan @yadvr @karuturi @DaanHoogland @kiwiflyer