CLOUDSTACK-9805: Display VR list in network details #1980
Conversation
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
Looks like just UI Changes. LGTM based on code review
|
Who (user type) has visibility tab of this tab? |
|
is there any issue for normal users ? |
|
@ustcweizhou @PaulAngus sure, I can add a tab filter to allow only admins to see this. Right now, whoever can see the network tab(s) can see this tab too. I'll fix this asap. |
|
tested. LGTM |
|
@PaulAngus @ustcweizhou fixed now, the tab is displayed only to admins. |
|
Is it only showing VR or other appliances providing service in that network? If it is the latter then the tab name is appropriate otherwise it is better to name it something like "Virtual Routers" to avoid confusion. |
|
@rhtyd Looks great! Shall we do the same for the VPC routers, so that the overviews look the same? |
|
@remibergsma thanks, I've found time to fix this now:
@koushik-das yes all cases checked and covered for vpc, shared networks and isolated networks. Label fixed to 'Virtual Routers' now. |
|
@DaanHoogland @abhinandanprateek @borisstoyanov @koushik-das @remibergsma @karuturi let's lgtm and merge this? thanks. |
Displays a VR tab that lists VRs for the network in the detail views for isolated networks, shared networks and for VPCs. Signed-off-by: Rohit Yadav <[email protected]>
|
Nice @rhtyd LGTM |
|
LGTM (based on code only) |
|
@rhtyd it seems we can discard 'router' in vpc part. |
|
@karuturi this is ready for merge, has the screenshots and lgtms |
|
@karuturi this is a simple UI change with screenshots attached, and has enough LGTM. Please merge this. |
|
@karuturi thanks for merging, just a note that merging from UI does not automatically fwd-merge the branch. Please do that too thanks :) |
8 participants
Displays a VR tab that lists VRs for the network in the detail views. This has come up several times, and useful for admins when they want to reboot/destroy or view VR associated with a network.
Pinging for review - @abhinandanprateek @borisstoyanov @DaanHoogland @PaulAngus @karuturi @koushik-das